Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/output/output_surface.h

Issue 640023004: cc: Make OutputSurface::SwapBuffers pure virtual (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@latinfo
Patch Set: and rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/output/output_surface.cc » ('j') | mojo/cc/direct_output_surface.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/output_surface.h
diff --git a/cc/output/output_surface.h b/cc/output/output_surface.h
index c79f770be920fb024a7918a836c11d35a578d09e..6cd0749aaf677ad02967fc499864476862ffc509 100644
--- a/cc/output/output_surface.h
+++ b/cc/output/output_surface.h
@@ -113,8 +113,10 @@ class CC_EXPORT OutputSurface {
// The implementation may destroy or steal the contents of the CompositorFrame
// passed in (though it will not take ownership of the CompositorFrame
- // itself).
- virtual void SwapBuffers(CompositorFrame* frame);
+ // itself). For successful swaps, the implementation must call
+ // OutputSurfaceClient::DidSwapBuffers() and eventually
+ // DidSwapBuffersComplete().
+ virtual void SwapBuffers(CompositorFrame* frame) = 0;
virtual void OnSwapBuffersComplete();
// Notifies frame-rate smoothness preference. If true, all non-critical
« no previous file with comments | « no previous file | cc/output/output_surface.cc » ('j') | mojo/cc/direct_output_surface.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698