Issue 639963005: Remove CachedUAStyle::hasAppearance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 639963005: Remove CachedUAStyle::hasAppearance. (Closed)

Created:
6 years, 2 months ago by andersr

Modified:
6 years, 2 months ago

Reviewers:
esprehn, rune

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove CachedUAStyle::hasAppearance. As of f885f9b1178fa278beafd201fb92a93af2117d64, this variable is now pointless, because the existence of a CachedUAStyle is only possible when 'hasAppearance' is 'true'. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183594

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	Source/core/rendering/RenderTheme.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/rendering/style/CachedUAStyle.h	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639963005/1

6 years, 2 months ago (2014-10-13 08:35:39 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-13 09:38:45 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183594

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages