Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 639933003: Add SkBBoxHierarchy::reserve() as an optional size hint. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add SkBBoxHierarchy::reserve() as an optional size hint. I want to play around with how SkTileGrid stores its tiles. Having a cap on the number of insert() calls can be pretty handy. While I'm at it, I gave flush() a default empty impl. Like reserve(), it's really an optional hook for subclasses. BUG=skia: Committed: https://skia.googlesource.com/skia/+/208d1704c2cc1161ea337a05155f2b9a04edd351

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/core/SkBBoxHierarchy.h View 2 chunks +9 lines, -4 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkTileGrid.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein
6 years, 2 months ago (2014-10-08 18:24:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639933003/1
6 years, 2 months ago (2014-10-08 18:25:26 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-08 18:25:26 UTC) #5
robertphillips
lgtm
6 years, 2 months ago (2014-10-08 18:51:31 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
6 years, 2 months ago (2014-10-08 21:17:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639933003/20001
6 years, 2 months ago (2014-10-09 13:38:42 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 13:49:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 208d1704c2cc1161ea337a05155f2b9a04edd351

Powered by Google App Engine
This is Rietveld 408576698