Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 639903003: Re-suppress WCVCDT.BadFramesGoodFrames (Closed)

Created:
6 years, 2 months ago by mark a. foltz
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang, miu
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-suppress WCVCDT.BadFramesGoodFrames BUG=159234 NOTRY=true Committed: https://crrev.com/65881718606646dd8fa7169460c766487a95d9f2 Cr-Commit-Position: refs/heads/master@{#299376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/content_unittests.gtest_mac.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mark a. foltz
Fails in Valgrind Mac waterfall. http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/30568/steps/memory%20test%3A%20content/logs/WebContentsVideoCaptureDeviceTest.BadFramesGoodFrames
6 years, 2 months ago (2014-10-13 18:41:15 UTC) #2
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-13 22:03:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639903003/1
6 years, 2 months ago (2014-10-13 22:04:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 22:05:37 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/65881718606646dd8fa7169460c766487a95d9f2 Cr-Commit-Position: refs/heads/master@{#299376}
6 years, 2 months ago (2014-10-13 22:06:41 UTC) #8
miu
6 years, 2 months ago (2014-10-13 22:49:56 UTC) #9
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698