ui/views/controls/button/menu_button.h - Issue 639893003: Unify MenuButton Pushed state logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/menu_button.h

Issue 639893003: Unify MenuButton Pushed state logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/button/menu_button.h

diff --git a/ui/views/controls/button/menu_button.h b/ui/views/controls/button/menu_button.h

index 1eedc0f7d6b0fc03654765fdf9020102460992a5..e43e052a7300ada8c2c795488fc928c8525b1f26 100644

--- a/ui/views/controls/button/menu_button.h

+++ b/ui/views/controls/button/menu_button.h

@@ -85,6 +85,9 @@ class VIEWS_EXPORT MenuButton : public LabelButton {

// Overridden from LabelButton:

virtual gfx::Rect GetChildAreaBounds() OVERRIDE;

+ // Overridden from MenuButton:

flackr 2014/10/14 14:11:06 Overridden from MenuButton? Isn't this MenuButton?

jonross 2014/10/14 16:00:48 Yup, meant CustomButton.

+ virtual bool ShouldEnterPushedState(const ui::Event& event) OVERRIDE;

// Offset of the associated menu position.

gfx::Point menu_offset_;