sky/tools/webkitpy/layout_tests/bisect_test_ordering.py - Issue 639883003: Get test_webkitpy to actually run again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/tools/webkitpy/layout_tests/bisect_test_ordering.py

Issue 639883003: Get test_webkitpy to actually run again. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: merge to ToT Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/tools/webkitpy/layout_tests/bisect_test_ordering.py

diff --git a/sky/tools/webkitpy/layout_tests/bisect_test_ordering.py b/sky/tools/webkitpy/layout_tests/bisect_test_ordering.py

index a10ed15fa9a4287787d74e0c390284b08829d435..5f3d80ad421c07e2c64005a93cf726e6c5654c6c 100644

--- a/sky/tools/webkitpy/layout_tests/bisect_test_ordering.py

+++ b/sky/tools/webkitpy/layout_tests/bisect_test_ordering.py

@@ -146,7 +146,7 @@ class Bisector(object):

def test_fails(self, tests):

extra_args = ['--debug'] if self.is_debug else []

- path_to_run_webkit_tests = self.webkit_finder.path_from_webkit_base('Tools', 'Scripts', 'run-webkit-tests')

+ path_to_run_webkit_tests = self.webkit_finder.path_from_webkit_base('tools', 'test_sky')

output = self.executive.popen([path_to_run_webkit_tests, '--child-processes', '1', '--order', 'none', '--no-retry', '--no-show-results', '--verbose'] + extra_args + tests, stdout=subprocess.PIPE, stderr=subprocess.PIPE)

failure_string = self.expected_failure + ' failed'

if failure_string in output.stderr.read():

« no previous file with comments | « sky/tools/webkitpy/common/webkit_finder.py ('k') | sky/tools/webkitpy/layout_tests/port/mock_drt.py » ('j') | no next file with comments »