Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 639883003: Get test_webkitpy to actually run again. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Get test_webkitpy to actually run again. -Fix all the Tools/Scripts paths to use tools. -Fix imports of deleted modules. -Delete SVN module TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/13a048957326c7318cbb1557f26120cb26243248

Patch Set 1 #

Patch Set 2 : merge to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -697 lines) Patch
M sky/tools/webkitpy/common/checkout/diff_parser_unittest.py View 5 chunks +15 lines, -15 lines 0 comments Download
M sky/tools/webkitpy/common/checkout/scm/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tools/webkitpy/common/checkout/scm/detection.py View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/tools/webkitpy/common/checkout/scm/scm_unittest.py View 3 chunks +0 lines, -372 lines 0 comments Download
D sky/tools/webkitpy/common/checkout/scm/svn.py View 1 chunk +0 lines, -202 lines 0 comments Download
M sky/tools/webkitpy/common/config/orderfile View 1 chunk +2 lines, -4 lines 0 comments Download
M sky/tools/webkitpy/common/system/executive_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/webkitpy/common/system/filesystem_mock.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/webkitpy/common/system/logutils_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tools/webkitpy/common/webkit_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/webkitpy/layout_tests/bisect_test_ordering.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/webkitpy/layout_tests/port/mock_drt.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/webkitpy/layout_tests/servers/pywebsocket.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/webkitpy/test/main.py View 2 chunks +2 lines, -15 lines 0 comments Download
M sky/tools/webkitpy/test/main_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/webkitpy/test/runner.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/webkitpy/tool/commands/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/tools/webkitpy/tool/commands/commitannouncer.py View 1 chunk +0 lines, -68 lines 0 comments Download
M sky/tools/webkitpy/tool/commands/rebaseline.py View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/webkitpy/tool/commands/rebaseline_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
Committed patchset #2 (id:20001) manually as 13a048957326c7318cbb1557f26120cb26243248 (presubmit successful).
6 years, 1 month ago (2014-10-26 18:17:53 UTC) #1
abarth-chromium
6 years, 1 month ago (2014-10-26 18:21:14 UTC) #2
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698