Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1883)

Issue 639873002: Use presence of a content key as non-scratch indicator (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@pp
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : minor #

Patch Set 4 : more #

Total comments: 2

Patch Set 5 : revert changes to rescache2 header #

Patch Set 6 : rebase, fixed? #

Patch Set 7 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -27 lines) Patch
M bench/GrResourceCacheBench.cpp View 1 2 3 4 5 1 chunk +8 lines, -1 line 0 comments Download
M include/gpu/GrGpuResource.h View 1 2 3 4 5 4 chunks +9 lines, -11 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 2 3 4 4 chunks +5 lines, -10 lines 0 comments Download
M src/gpu/GrResourceCache2.cpp View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
bsalomon
Removes the fIsScratch hack.
6 years, 2 months ago (2014-10-08 15:19:49 UTC) #2
robertphillips
lgtm + a question https://codereview.chromium.org/639873002/diff/60001/src/gpu/GrResourceCache2.h File src/gpu/GrResourceCache2.h (right): https://codereview.chromium.org/639873002/diff/60001/src/gpu/GrResourceCache2.h#newcode12 src/gpu/GrResourceCache2.h:12: #include "GrGpuResource.h" Do we need ...
6 years, 2 months ago (2014-10-08 17:29:31 UTC) #3
bsalomon
https://codereview.chromium.org/639873002/diff/60001/src/gpu/GrResourceCache2.h File src/gpu/GrResourceCache2.h (right): https://codereview.chromium.org/639873002/diff/60001/src/gpu/GrResourceCache2.h#newcode12 src/gpu/GrResourceCache2.h:12: #include "GrGpuResource.h" On 2014/10/08 17:29:31, robertphillips wrote: > Do ...
6 years, 2 months ago (2014-10-08 17:32:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639873002/80001
6 years, 2 months ago (2014-10-08 17:33:34 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 9eefe0851eeaa8ded05b4774ebcb38ed201d5dbf
6 years, 2 months ago (2014-10-08 17:48:21 UTC) #7
bsalomon
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/642493003/ by bsalomon@google.com. ...
6 years, 2 months ago (2014-10-08 18:21:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639873002/120001
6 years, 2 months ago (2014-10-09 16:49:45 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 16:57:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as 1e2530babb65a883a01df5ee87147432f6707ce3

Powered by Google App Engine
This is Rietveld 408576698