gin/modules/module_runner_delegate.h - Issue 639833004: change more OVERRIDE instances to override in gin/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gin/modules/module_runner_delegate.h

Issue 639833004: change more OVERRIDE instances to override in gin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « gin/modules/module_registry_unittest.cc ('k') | gin/modules/timer.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef GIN_MODULES_MODULE_RUNNER_DELEGATE_H_	5 #ifndef GIN_MODULES_MODULE_RUNNER_DELEGATE_H_

6 #define GIN_MODULES_MODULE_RUNNER_DELEGATE_H_	6 #define GIN_MODULES_MODULE_RUNNER_DELEGATE_H_

7	7

8 #include <map>	8 #include <map>

9	9

10 #include "base/callback.h"	10 #include "base/callback.h"

(...skipping 23 matching lines...) Expand all Loading...
34	34

35 protected:	35 protected:

36 void AttemptToLoadMoreModules(Runner* runner);	36 void AttemptToLoadMoreModules(Runner* runner);

37	37

38 private:	38 private:

39 typedef std::map<std::string, ModuleGetterCallback> BuiltinModuleMap;	39 typedef std::map<std::string, ModuleGetterCallback> BuiltinModuleMap;

40	40

41 // From ShellRunnerDelegate:	41 // From ShellRunnerDelegate:

42 virtual v8::Handle<v8::ObjectTemplate> GetGlobalTemplate(	42 virtual v8::Handle<v8::ObjectTemplate> GetGlobalTemplate(

43 ShellRunner* runner,	43 ShellRunner* runner,

44 v8::Isolate* isolate) OVERRIDE;	44 v8::Isolate* isolate) override;

45 virtual void DidCreateContext(ShellRunner* runner) OVERRIDE;	45 virtual void DidCreateContext(ShellRunner* runner) override;

46 virtual void DidRunScript(ShellRunner* runner) OVERRIDE;	46 virtual void DidRunScript(ShellRunner* runner) override;

47	47

48 BuiltinModuleMap builtin_modules_;	48 BuiltinModuleMap builtin_modules_;

49 FileModuleProvider module_provider_;	49 FileModuleProvider module_provider_;

50	50

51 DISALLOW_COPY_AND_ASSIGN(ModuleRunnerDelegate);	51 DISALLOW_COPY_AND_ASSIGN(ModuleRunnerDelegate);

52 };	52 };

53	53

54 } // namespace gin	54 } // namespace gin

55	55

56 #endif // GIN_MODULES_MODULE_RUNNER_DELEGATE_H_	56 #endif // GIN_MODULES_MODULE_RUNNER_DELEGATE_H_

OLD	NEW