|
|
Created:
6 years, 2 months ago by Thiemo Nagel Modified:
6 years, 2 months ago CC:
chromium-reviews, asvitkine+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
Descriptionbase::ImportantFileWriter: Add histogram entry for flush error.
This is and addendum to 604e5c18 (commit 300230), cf.
https://codereview.chromium.org/663463002/ .
BUG=none
Committed: https://crrev.com/d704ce056777a651c23d31e9f12bf45490a630b5
Cr-Commit-Position: refs/heads/master@{#300513}
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
tnagel@chromium.org changed reviewers: + asvitkine@google.com, rvargas@chromium.org
tnagel@chromium.org changed required reviewers: + asvitkine@google.com, rvargas@chromium.org
Hi Alexei, Ricardo, this now the last of the UMA/ImportantFileWriter CLs. Could you please take a look? Thank you! Thiemo
tnagel@chromium.org changed reviewers: + asvitkine@chromium.org - asvitkine@google.com
tnagel@chromium.org changed required reviewers: + asvitkine@chromium.org - asvitkine@google.com
The CQ bit was checked by asvitkine@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639823009/1
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Alexei, I think I accidentally sent the review to your @google.com address. Could that be the reason why commit doesn't work?
tnagel@chromium.org changed required reviewers: - rvargas@chromium.org
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639823009/1
On 2014/10/21 14:48:11, Thiemo Nagel wrote: > Alexei, I think I accidentally sent the review to your @google.com address. > Could that be the reason why commit doesn't work? The above is not correct. Actually, the problem was the * before Ricardo's name. Sorry for the noise!
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639823009/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d704ce056777a651c23d31e9f12bf45490a630b5 Cr-Commit-Position: refs/heads/master@{#300513} |