Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 639823009: base::ImportantFileWriter: Add histogram entry for flush error. (Closed)

Created:
6 years, 2 months ago by Thiemo Nagel
Modified:
6 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

base::ImportantFileWriter: Add histogram entry for flush error. This is and addendum to 604e5c18 (commit 300230), cf. https://codereview.chromium.org/663463002/ . BUG=none Committed: https://crrev.com/d704ce056777a651c23d31e9f12bf45490a630b5 Cr-Commit-Position: refs/heads/master@{#300513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Thiemo Nagel
Hi Alexei, Ricardo, this now the last of the UMA/ImportantFileWriter CLs. Could you please take ...
6 years, 2 months ago (2014-10-21 08:17:08 UTC) #3
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-10-21 14:43:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639823009/1
6 years, 2 months ago (2014-10-21 14:44:37 UTC) #8
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
6 years, 2 months ago (2014-10-21 14:44:40 UTC) #10
Thiemo Nagel
Alexei, I think I accidentally sent the review to your @google.com address. Could that be ...
6 years, 2 months ago (2014-10-21 14:48:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639823009/1
6 years, 2 months ago (2014-10-21 14:49:18 UTC) #14
Thiemo Nagel
On 2014/10/21 14:48:11, Thiemo Nagel wrote: > Alexei, I think I accidentally sent the review ...
6 years, 2 months ago (2014-10-21 14:51:45 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27648)
6 years, 2 months ago (2014-10-21 16:39:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639823009/1
6 years, 2 months ago (2014-10-21 16:49:58 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 17:26:43 UTC) #20
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 17:28:01 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d704ce056777a651c23d31e9f12bf45490a630b5
Cr-Commit-Position: refs/heads/master@{#300513}

Powered by Google App Engine
This is Rietveld 408576698