Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 639823008: Include load_time_data.js automatically with GetI18nTemplateHtml (Closed)

Created:
6 years, 2 months ago by Evan Stade
Modified:
6 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Include load_time_data.js automatically with GetI18nTemplateHtml BUG=420001 Committed: https://crrev.com/6fb26395a6a97cc2fca1bfd0764751a072080de2 Cr-Commit-Position: refs/heads/master@{#299551}

Patch Set 1 #

Patch Set 2 : remove explicit includes #

Total comments: 2

Patch Set 3 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M chrome/browser/resources/about_sys/about_sys.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/merge_session_load.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/mobile_setup.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/mobile_setup_portal.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/proxy_settings.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/sim_unlock.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp4/guest_tab.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp4/incognito_tab.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.html View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/resources/supervised_user_block_interstitial.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/webui/jstemplate_builder.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
6 years, 2 months ago (2014-10-13 19:18:27 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/639823008/diff/40001/ui/base/webui/jstemplate_builder.cc File ui/base/webui/jstemplate_builder.cc (right): https://codereview.chromium.org/639823008/diff/40001/ui/base/webui/jstemplate_builder.cc#newcode37 ui/base/webui/jstemplate_builder.cc:37: // Appends the source for JsTemplates in a ...
6 years, 2 months ago (2014-10-13 19:20:48 UTC) #3
Evan Stade
https://codereview.chromium.org/639823008/diff/40001/ui/base/webui/jstemplate_builder.cc File ui/base/webui/jstemplate_builder.cc (right): https://codereview.chromium.org/639823008/diff/40001/ui/base/webui/jstemplate_builder.cc#newcode37 ui/base/webui/jstemplate_builder.cc:37: // Appends the source for JsTemplates in a script ...
6 years, 2 months ago (2014-10-13 19:26:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639823008/210001
6 years, 2 months ago (2014-10-14 20:57:56 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:210001)
6 years, 2 months ago (2014-10-14 21:22:14 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 21:51:16 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6fb26395a6a97cc2fca1bfd0764751a072080de2
Cr-Commit-Position: refs/heads/master@{#299551}

Powered by Google App Engine
This is Rietveld 408576698