Source/core/css/MediaValues.h - Issue 639783002: Media query values should not be 0 when overflowed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaValues.h

Issue 639783002: Media query values should not be 0 when overflowed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/MediaValues.h

diff --git a/Source/core/css/MediaValues.h b/Source/core/css/MediaValues.h

index d306ac43029692f7d6a8f4cab5a4abb09f1f26d8..0ab4a9a97c3a75d09950f3cf06f9f1ccf8d8a9fd 100644

--- a/Source/core/css/MediaValues.h

+++ b/Source/core/css/MediaValues.h

@@ -37,7 +37,14 @@ public:

double tempResult;

if (!computeLengthImpl(value, type, defaultFontSize, viewportWidth, viewportHeight, tempResult))

return false;

- result = roundForImpreciseConversion<T>(tempResult);

+ if (tempResult > std::numeric_limits<T>::max())

+ result = std::numeric_limits<T>::max();

+ else if (tempResult < std::numeric_limits<T>::min())

+ result = std::numeric_limits<T>::min();

+ else

+ result = static_cast<T>(tempResult);

rune 2014/10/08 12:26:39 There is a clampTo templated method you could use.

return true;

}

virtual bool computeLength(double value, CSSPrimitiveValue::UnitType, int& result) const = 0;

« no previous file with comments | « LayoutTests/fast/media/media-query-overflow-value-expected.txt ('k') | no next file » | no next file with comments »