LayoutTests/fast/media/media-query-overflow-value.html - Issue 639783002: Media query values should not be 0 when overflowed

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/media/media-query-overflow-value.html

Issue 639783002: Media query values should not be 0 when overflowed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>
	Yoav Weiss 2014/10/10 07:33:49 nit: We usually don't include the doctype + html + nit: We usually don't include the doctype + html + head boilerplate in layout tests rune 2014/10/10 07:52:55 doctype should be there, for sure, preferable upca Show quoted text On 2014/10/10 07:33:49, Yoav Weiss wrote: > nit: We usually don't include the doctype + html + head boilerplate in layout > tests doctype should be there, for sure, preferable upcased as "<!DOCTYPE html>", unless you're actually testing quirks. html/head/body are usually left out.
	4 <script>

	5 if (window.testRunner)

	6 testRunner.dumpAsText();

	7 function log(m)

	8 {

	9 var results = document.getElementById('results');

	10 results.innerHTML += m + '<br>';

	11 }

	12 function testQuery(query, expected)
	Yoav Weiss 2014/10/10 07:33:49 nit: Can you add a newline above functions? nit: Can you add a newline above functions?
	13 {

	14 var isTrue = window.matchMedia(query).matches;

	15 var message = '\"' + query + '\" evaluates to ' + (isTrue ? 'true' : 'fa lse');

	16 message += (isTrue == expected) ? ': PASS' : ': FAIL';

	17 log(message);

	18 }

	19 function runTests()

	20 {

	21 testQuery('(min-width: 9999999999px)', false);

	22 testQuery('(max-width: 9999999999px)', true);

	23 testQuery('(min-device-width: 9999999999px)', false);

	24 testQuery('(max-device-width: 9999999999px)', true);

	25 testQuery('(min-height: 9999999999px)', false);

	26 testQuery('(max-height: 9999999999px)', true);

	27 testQuery('(min-device-height: 9999999999px)', false);

	28 testQuery('(max-device-height: 9999999999px)', true);

	29 }

	30 </script>

	31 </head>

	32 <body onload="runTests()">

	33 <p>Test MediaQuery values that overflow int range</p>

	34 <div id="results">

	35 </div>

	36 </body>

	37 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/media/media-query-overflow-value-expected.txt » ('j') | no next file with comments »