Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 639773012: On Android, unlabeled link containing image should use image url as name. (Closed)

Created:
6 years, 1 month ago by dmazzoni
Modified:
6 years, 1 month ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@link_visible_text
Project:
chromium
Visibility:
Public.

Description

On Android, unlabeled link containing image should use image url as name. This is just a heuristic to handle a situation where neither the link or image are labeled. Since we can only export a single name attribute on Android - unlike other systems where we export several fields and let the assistive technology decide - this tries to do the sensible thing when there's a link containing an image. BUG=386623 Committed: https://crrev.com/9526014c463ad05c36c8f69eb3ce0f5ac053a411 Cr-Commit-Position: refs/heads/master@{#301390}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M content/browser/accessibility/browser_accessibility_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 1 2 chunks +17 lines, -2 lines 0 comments Download
M content/test/data/accessibility/a-no-text.html View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/a-no-text-expected-android.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dmazzoni
6 years, 1 month ago (2014-10-24 18:03:43 UTC) #2
Peter Lundblad
lgtm
6 years, 1 month ago (2014-10-27 09:48:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639773012/1
6 years, 1 month ago (2014-10-27 09:49:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/73827) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/16444) android_clang_dbg_recipe ...
6 years, 1 month ago (2014-10-27 09:51:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639773012/20001
6 years, 1 month ago (2014-10-27 16:27:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 17:23:08 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 17:23:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9526014c463ad05c36c8f69eb3ce0f5ac053a411
Cr-Commit-Position: refs/heads/master@{#301390}

Powered by Google App Engine
This is Rietveld 408576698