Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 639773003: Revert of Make GM default to reseting gpu contexts on android. (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Make GM default to reseting gpu contexts on android. (patchset #1 id:1 of https://codereview.chromium.org/635293003/) Reason for revert: Crashing on Galaxy Nexus (probably tickled an existing skia or driver bug) Original issue's description: > Make GM default to reseting gpu contexts on android. > > TBR=mtklein@google.com > > Committed: https://skia.googlesource.com/skia/+/8dd35ce178e4319685a870faf544a0b1d7aef5bb TBR=mtklein@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/7663d66681a8b695b36701c6885935c60c0531c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M gm/gmmain.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
Created Revert of Make GM default to reseting gpu contexts on android.
6 years, 2 months ago (2014-10-08 12:40:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639773003/1
6 years, 2 months ago (2014-10-08 12:41:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7663d66681a8b695b36701c6885935c60c0531c3
6 years, 2 months ago (2014-10-08 12:41:29 UTC) #3
mtklein
On 2014/10/08 12:41:29, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 2 months ago (2014-10-08 13:23:31 UTC) #4
bsalomon
On 2014/10/08 13:23:31, mtklein wrote: > On 2014/10/08 12:41:29, I haz the power (commit-bot) wrote: ...
6 years, 2 months ago (2014-10-08 13:32:31 UTC) #5
bsalomon
6 years, 2 months ago (2014-10-08 13:33:07 UTC) #6
Message was sent while issue was closed.
On 2014/10/08 13:32:31, bsalomon wrote:
> On 2014/10/08 13:23:31, mtklein wrote:
> > On 2014/10/08 12:41:29, I haz the power (commit-bot) wrote:
> > > Committed patchset #1 (id:1) as 7663d66681a8b695b36701c6885935c60c0531c3
> > 
> > Weird.  Don't we do this on all bots in DM?  Looks like it's working fine
> there.
> 
> Yup, also I ran tries with this combined with other resource caches and it ran
> just fine. I think the GN drivers are just really buggy and tickling them the
> wrong way can cause a crash. I'm trying a different approach here:
> https://codereview.chromium.org/640643004/

I meant "resource cache changes"

Powered by Google App Engine
This is Rietveld 408576698