Issue 639753007: Revert "Make all references from root shortcuts (except one to GC roots)"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 639753007: Revert "Make all references from root shortcuts (except one to GC roots)" (Closed)

Created:
6 years, 1 month ago by yurys

Modified:
6 years, 1 month ago

Reviewers:
Yang, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert "Make all references from root shortcuts (except one to GC roots)" This reverts commit 940418d2e1150499a28cca60b5dd138d351ec652. It resulted in orphan (Document DOM trees) and (Detached DOM trees) nodes. BUG=chromium:414190 LOG=N TBR=loislo@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24903

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/heap-snapshot-generator.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

yurys

Committed patchset #1 (id:1) manually as 24903 (presubmit successful).

6 years, 1 month ago (2014-10-27 12:37:48 UTC) #1

Yang

6 years, 1 month ago (2014-10-27 12:45:05 UTC) #2

Message was sent while issue was closed.

On 2014/10/27 12:37:48, yurys wrote:
> Committed patchset #1 (id:1) manually as 24903 (presubmit successful).

lgtm.