Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: testing/test_env.py

Issue 639713009: Pass extra env variables also to the symbolizer script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test_env.py
diff --git a/testing/test_env.py b/testing/test_env.py
index 1a41790d6c7bd134199e046c01adcccfbbff7ffa..4c194277bf33090c31097025cf7c85064413a10a 100755
--- a/testing/test_env.py
+++ b/testing/test_env.py
@@ -174,10 +174,11 @@ def run_executable(cmd, env):
p1 = subprocess.Popen(cmd, env=env, stdout=subprocess.PIPE,
stderr=sys.stdout)
p2 = subprocess.Popen(["../tools/valgrind/asan/asan_symbolize.py"],
- stdin=p1.stdout)
+ env=env, stdin=p1.stdout)
p1.stdout.close() # Allow p1 to receive a SIGPIPE if p2 exits.
+ p1.wait()
p2.wait()
- return p2.returncode
+ return p1.returncode
else:
return subprocess.call(cmd, env=env)
except OSError:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698