Pass extra env variables also to the symbolizer script.

Pass extra env variables also to the symbolizer script.

In particular LLVM_SYMBOLIZER_PATH is needed by asan_symbolize.py.

Also explicitly wait for test launcher to finish running and use its return
code as an overall exit code of the test. asan_symbolize.py always returns
0 (if it doesn't crash), not very useful.

BUG=424280
R=earthdok@chromium.org

Committed: https://crrev.com/1eaeb298383496bc150b75bfab399dbcb650c0ab
Cr-Commit-Position: refs/heads/master@{#300252}

[Vadim Sh., 2014-10-20 11:44:48]

ptal

LLVM_SYMBOLIZER_PATH wasn't actually passed to asan_symbolizer.py.

[earthdok, 2014-10-20 11:51:00]

On 2014/10/20 11:44:48, Vadim Sh. wrote:
> ptal
> 
> LLVM_SYMBOLIZER_PATH wasn't actually passed to asan_symbolizer.py.

Actually, LLVM_SYMBOLIZER_PATH isn't required if asan_symbolize.py is run from a
normal checkout:

https://code.google.com/p/chromium/codesearch#chromium/src/tools/valgrind/asa...

but I assume the paths are different in swarming jobs, so lgtm.

[Vadim Sh., 2014-10-20 11:58:39]

On 2014/10/20 11:51:00, earthdok wrote:
> On 2014/10/20 11:44:48, Vadim Sh. wrote:
> > ptal
> > 
> > LLVM_SYMBOLIZER_PATH wasn't actually passed to asan_symbolizer.py.
> 
> Actually, LLVM_SYMBOLIZER_PATH isn't required if asan_symbolize.py is run from
a
> normal checkout:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/valgrind/asa...
> 
> but I assume the paths are different in swarming jobs, so lgtm.

:-/

Swarming directory structure is identical to src/* (a strict subset), so this
code path should have worked too. 
Maybe it IS working, LLVMSymbolizer just fails and asan_symbolize.py falls back
to system default symbolizer (and it fails too).

Regardless, I'll commit the CL to be absolutely sure.

[Vadim Sh., 2014-10-20 11:58:42]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2014-10-20 11:58:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/639713009/1

[commit-bot: I haz the power, 2014-10-20 12:28:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-20 12:30:15]

Patchset 1 (id:??) landed as
https://crrev.com/1eaeb298383496bc150b75bfab399dbcb650c0ab
Cr-Commit-Position: refs/heads/master@{#300252}