Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 639713007: Fix a QUIC flow control bug where a stream is flow control blocked when (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett
Base URL:
https://chromium.googlesource.com/chromium/src.git@Set_server_idle_timeout_76821863_2
Project:
chromium
Visibility:
Public.

Description

Fix a QUIC flow control bug where a stream is flow control blocked when the config is negotiated and it never gets to write again. Merge internal change: 77003200 R=rch@chromium.org BUG=423024 Committed: https://crrev.com/37f60c064e5fa7e7370ccdc4a806dc8277abeaf4 Cr-Commit-Position: refs/heads/master@{#299339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M net/quic/quic_flow_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
ramant (doing other things)
6 years, 2 months ago (2014-10-11 02:44:50 UTC) #1
Ryan Hamilton
lgtm
6 years, 2 months ago (2014-10-13 17:57:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639713007/1
6 years, 2 months ago (2014-10-13 18:17:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639713007/1
6 years, 2 months ago (2014-10-13 18:18:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 19:19:28 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:20:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37f60c064e5fa7e7370ccdc4a806dc8277abeaf4
Cr-Commit-Position: refs/heads/master@{#299339}

Powered by Google App Engine
This is Rietveld 408576698