content/browser/web_contents/web_contents_impl.cc - Issue 639703004: Optimizing DateTimeAndroid and ColorChooserAndroid initializations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 639703004: Optimizing DateTimeAndroid and ColorChooserAndroid initializations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the review comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/date_time_chooser_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index e6ee4cf2a1f398cd19129e468fd44eebe6cad981..41bf3a5986e89ec9fe252e22af853b5f6914bcc8 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -104,11 +104,9 @@

#include "ui/gl/gl_switches.h"

#if defined(OS_ANDROID)

-#include "content/browser/android/content_view_core_impl.h"

#include "content/browser/android/date_time_chooser_android.h"

#include "content/browser/media/android/browser_media_player_manager.h"

#include "content/browser/web_contents/web_contents_android.h"

-#include "content/public/browser/android/content_view_core.h"

#endif

#if defined(OS_MACOSX)

@@ -2865,7 +2863,7 @@ void WebContentsImpl::OnFindMatchRectsReply(

void WebContentsImpl::OnOpenDateTimeDialog(

const ViewHostMsg_DateTimeDialogValue_Params& value) {

- date_time_chooser_->ShowDialog(ContentViewCore::FromWebContents(this),

+ date_time_chooser_->ShowDialog(GetTopLevelNativeWindow(),

GetRenderViewHost(),

value.dialog_type,

value.dialog_value,