content/browser/android/date_time_chooser_android.h - Issue 639703004: Optimizing DateTimeAndroid and ColorChooserAndroid initializations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/date_time_chooser_android.h

Issue 639703004: Optimizing DateTimeAndroid and ColorChooserAndroid initializations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the review comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_contents_delegate_android/color_chooser_android.cc ('k') | content/browser/android/date_time_chooser_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/date_time_chooser_android.h

diff --git a/content/browser/android/date_time_chooser_android.h b/content/browser/android/date_time_chooser_android.h

index b47ed5ec7c5f38e51234fb9873d580c61b0ef354..1a29b4a0f0597fcef438f6c27afad52fe6be693a 100644

--- a/content/browser/android/date_time_chooser_android.h

+++ b/content/browser/android/date_time_chooser_android.h

@@ -11,6 +11,7 @@

#include "base/android/jni_weak_ref.h"

#include "base/memory/scoped_ptr.h"

#include "ui/base/ime/text_input_type.h"

+#include "ui/gfx/native_widget_types.h"

namespace content {

@@ -27,7 +28,7 @@ class DateTimeChooserAndroid {

// DateTimeChooser implementation:

// Shows the dialog. |dialog_value| is the date/time value converted to a

// number as defined in HTML. (See blink::InputType::parseToNumber())

- void ShowDialog(ContentViewCore* content,

+ void ShowDialog(gfx::NativeWindow native_window,

RenderViewHost* host,

ui::TextInputType dialog_type,

double dialog_value,