content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java - Issue 639703004: Optimizing DateTimeAndroid and ColorChooserAndroid initializations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java

Issue 639703004: Optimizing DateTimeAndroid and ColorChooserAndroid initializations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reverted untouched blank line. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java b/content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java

index a673d32a13219a0bfaafd6c10add9bcc6f76fbb2..f3d3f6819fb8dd76f1acf82334d69a779bc6df20 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/DateTimeChooserAndroid.java

@@ -8,7 +8,7 @@ import android.content.Context;

import org.chromium.base.CalledByNative;

import org.chromium.base.JNINamespace;

-import org.chromium.content.browser.ContentViewCore;

+import org.chromium.ui.base.WindowAndroid;

import org.chromium.ui.picker.DateTimeSuggestion;

import org.chromium.ui.picker.InputDialogContainer;

@@ -47,14 +47,14 @@ class DateTimeChooserAndroid {

@CalledByNative

private static DateTimeChooserAndroid createDateTimeChooser(

- ContentViewCore contentViewCore,

+ WindowAndroid windowAndroid,

long nativeDateTimeChooserAndroid,

int dialogType, double dialogValue,

double min, double max, double step,

DateTimeSuggestion[] suggestions) {

DateTimeChooserAndroid chooser =

new DateTimeChooserAndroid(

- contentViewCore.getContext(),

+ windowAndroid.getActivity().get(),

nativeDateTimeChooserAndroid);

chooser.showDialog(dialogType, dialogValue, min, max, step, suggestions);

return chooser;