Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: content/browser/android/date_time_chooser_android.cc

Issue 639703004: Optimizing DateTimeAndroid and ColorChooserAndroid initializations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nits. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/date_time_chooser_android.cc
diff --git a/content/browser/android/date_time_chooser_android.cc b/content/browser/android/date_time_chooser_android.cc
index 58133ba22d96d03248ca1deaf7702b813d1ccfd2..111d43e0ebb449065f505b9c582f370fc963ebae 100644
--- a/content/browser/android/date_time_chooser_android.cc
+++ b/content/browser/android/date_time_chooser_android.cc
@@ -9,7 +9,6 @@
#include "base/i18n/char_iterator.h"
#include "content/common/date_time_suggestion.h"
#include "content/common/view_messages.h"
-#include "content/public/browser/android/content_view_core.h"
#include "content/public/browser/render_view_host.h"
#include "jni/DateTimeChooserAndroid_jni.h"
#include "third_party/icu/source/common/unicode/uchar.h"
@@ -73,7 +72,7 @@ void DateTimeChooserAndroid::CancelDialog(JNIEnv* env, jobject) {
}
void DateTimeChooserAndroid::ShowDialog(
- ContentViewCore* content,
+ WebContents* webcontents,
RenderViewHost* host,
ui::TextInputType dialog_type,
double dialog_value,
@@ -104,7 +103,7 @@ void DateTimeChooserAndroid::ShowDialog(
j_date_time_chooser_.Reset(Java_DateTimeChooserAndroid_createDateTimeChooser(
env,
- content->GetJavaObject().obj(),
+ webcontents->GetJavaWebContents().obj(),
Ted C 2014/10/15 21:32:42 I want to agree with Yaron that context definitely
AKVT 2014/10/29 18:13:28 Done. Thank you
reinterpret_cast<intptr_t>(this),
dialog_type,
dialog_value,

Powered by Google App Engine
This is Rietveld 408576698