Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: content/browser/android/date_time_chooser_android.h

Issue 639703004: Optimizing DateTimeAndroid and ColorChooserAndroid initializations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nits. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_ 5 #ifndef CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_
6 #define CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_ 6 #define CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/android/jni_weak_ref.h" 11 #include "base/android/jni_weak_ref.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "content/public/browser/web_contents.h"
13 #include "ui/base/ime/text_input_type.h" 14 #include "ui/base/ime/text_input_type.h"
14 15
15 namespace content { 16 namespace content {
16 17
17 class ContentViewCore; 18 class ContentViewCore;
Yaron 2014/10/15 20:32:38 remove
AKVT 2014/10/29 18:13:29 Done.
18 class RenderViewHost; 19 class RenderViewHost;
19 struct DateTimeSuggestion; 20 struct DateTimeSuggestion;
20 21
21 // Android implementation for DateTimeChooser dialogs. 22 // Android implementation for DateTimeChooser dialogs.
22 class DateTimeChooserAndroid { 23 class DateTimeChooserAndroid {
23 public: 24 public:
24 DateTimeChooserAndroid(); 25 DateTimeChooserAndroid();
25 ~DateTimeChooserAndroid(); 26 ~DateTimeChooserAndroid();
26 27
27 // DateTimeChooser implementation: 28 // DateTimeChooser implementation:
28 // Shows the dialog. |dialog_value| is the date/time value converted to a 29 // Shows the dialog. |dialog_value| is the date/time value converted to a
29 // number as defined in HTML. (See blink::InputType::parseToNumber()) 30 // number as defined in HTML. (See blink::InputType::parseToNumber())
30 void ShowDialog(ContentViewCore* content, 31 void ShowDialog(WebContents* webcontents,
Yaron 2014/10/15 20:32:38 web_contents
AKVT 2014/10/29 18:13:29 Done.
31 RenderViewHost* host, 32 RenderViewHost* host,
32 ui::TextInputType dialog_type, 33 ui::TextInputType dialog_type,
33 double dialog_value, 34 double dialog_value,
34 double min, 35 double min,
35 double max, 36 double max,
36 double step, 37 double step,
37 const std::vector<DateTimeSuggestion>& suggestions); 38 const std::vector<DateTimeSuggestion>& suggestions);
38 39
39 // Replaces the current value 40 // Replaces the current value
40 void ReplaceDateTime(JNIEnv* env, jobject, jdouble value); 41 void ReplaceDateTime(JNIEnv* env, jobject, jdouble value);
(...skipping 15 matching lines...) Expand all
56 57
57 DISALLOW_COPY_AND_ASSIGN(DateTimeChooserAndroid); 58 DISALLOW_COPY_AND_ASSIGN(DateTimeChooserAndroid);
58 }; 59 };
59 60
60 // Native JNI methods 61 // Native JNI methods
61 bool RegisterDateTimeChooserAndroid(JNIEnv* env); 62 bool RegisterDateTimeChooserAndroid(JNIEnv* env);
62 63
63 } // namespace content 64 } // namespace content
64 65
65 #endif // CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_ 66 #endif // CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698