Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 639703003: Collect use counter for v8BreakIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/Source/bindings/core/v8/V8PerIsolateData.cpp b/Source/bindings/core/v8/V8PerIsolateData.cpp
index bfca715e18ab407bc1631c1be874600e8220e350..75e1dde0a9e159b5b7ff48c206c5fd0fb2ec0d14 100644
--- a/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -56,10 +56,11 @@ static void useCounterCallback(v8::Isolate* isolate, v8::Isolate::UseCounterFeat
case v8::Isolate::kUseAsm:
UseCounter::count(currentExecutionContext(isolate), UseCounter::UseAsm);
break;
+ case v8::Isolate::kBreakIterator:
+ UseCounter::count(currentExecutionContext(isolate), UseCounter::BreakIterator);
haraken 2014/10/14 11:01:41 Are you sure that you want to use currentExecution
Erik Corry Chromium.org 2014/10/14 11:21:00 I'm doing the same as the kUseAsm counter does. I
marja 2014/10/14 11:23:20 haraken@: ultimately both get associated to the Fr
haraken 2014/10/14 11:29:43 If the current execution context is a document of
+ break;
default:
- // V8 may be a newer version that has some use counters we don't know
- // about yet. FIXME: Add support for v8::Isolate::kBreakIterator and
- // UseCounter::BreakIterator.
+ ASSERT_NOT_REACHED();
break;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698