Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Unified Diff: src/top.h

Issue 6397011: Make exception thrown via v8 public API propagate to v8::TryCatch as JS thrown exceptions do. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/top.h
diff --git a/src/top.h b/src/top.h
index 5b0fd6157cbd4da5c822e1442ea47824a4eecf85..58841abfb1380f25392b5203d37fe2470e97592c 100644
--- a/src/top.h
+++ b/src/top.h
@@ -240,13 +240,6 @@ class Top {
thread_local_.scheduled_exception_ = Heap::the_hole_value();
}
- static void setup_external_caught() {
- thread_local_.external_caught_exception_ =
- has_pending_exception() &&
- (thread_local_.catcher_ != NULL) &&
- (try_catch_handler() == thread_local_.catcher_);
- }
-
static void SetCaptureStackTraceForUncaughtExceptions(
bool capture,
int frame_limit,
@@ -452,6 +445,17 @@ class Top {
static const char* kStackOverflowMessage;
private:
+
+ static void setup_external_caught() {
+ thread_local_.external_caught_exception_ =
+ has_pending_exception() &&
+ (thread_local_.catcher_ != NULL) &&
+ (try_catch_handler() == thread_local_.catcher_);
+ }
+
+ // Attempts to propagate the pending exception to the proper v8::TryCatch.
+ static void PropagatePendingExceptionToExteranlTryCatch();
Mads Ager (chromium) 2011/01/28 11:39:18 Exteranl -> External
antonm 2011/01/28 13:37:25 Done.
+
#ifdef ENABLE_VMSTATE_TRACKING
// Set of states used when communicating with the runtime profiler.
//

Powered by Google App Engine
This is Rietveld 408576698