Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 639693005: Adding more webview browser tests to app_shell_browsertests. (Closed)

Created:
6 years, 2 months ago by Xi Han
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou, lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Fady Samuel, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding more webview browser tests to app_shell_browsertests. This CL includes the following tests: - WebViewAPITest.AcceptTouchEvents - WebViewAPITest.EmbedderVisibilityChanged - WebViewAPITest.GuestVisibilityChanged - WebViewAPITest.ReloadEmbedder BUG=352293 Committed: https://crrev.com/fcd89aea77ff46248d95e642977c759b121c4a3e Cr-Commit-Position: refs/heads/master@{#299243}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Small changes are made. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, --2 lines) Patch
M extensions/browser/guest_view/web_view/web_view_apitest.h View 1 chunk +10 lines, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 6 chunks +134 lines, -3 lines 0 comments Download
A + extensions/test/data/web_view/accept_touch_events/guest.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/web_view/accept_touch_events/guest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/web_view/accept_touch_events/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/web_view/accept_touch_events/main.js View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/test/data/web_view/accept_touch_events/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/web_view/accept_touch_events/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/web_view/visibility_changed/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/web_view/visibility_changed/main.js View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/test/data/web_view/visibility_changed/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/web_view/visibility_changed/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Xi Han
6 years, 2 months ago (2014-10-09 21:11:19 UTC) #3
lazyboy
lgtm Also rename the CL description a bit, this is not "move", more like adding/copying ...
6 years, 2 months ago (2014-10-10 02:24:56 UTC) #4
Xi Han
yoz@chromium.org: Please review all changes. Thanks!
6 years, 2 months ago (2014-10-10 13:11:40 UTC) #6
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-10-10 22:41:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639693005/290001
6 years, 2 months ago (2014-10-11 10:56:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:290001)
6 years, 2 months ago (2014-10-11 11:00:03 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 11:01:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fcd89aea77ff46248d95e642977c759b121c4a3e
Cr-Commit-Position: refs/heads/master@{#299243}

Powered by Google App Engine
This is Rietveld 408576698