Issue 63963002: Remove unused implementations in WebInbandTextTrackImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63963002: Remove unused implementations in WebInbandTextTrackImpl (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
acolwell GONE FROM CHROMIUM, Matthew Heaney (Chromium)

CC:
chromium-reviews, fischman+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove unused implementations in WebInbandTextTrackImpl These functions have been removed from WebInbandTextTrack. BUG=315257, 315270, 315476 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233835

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -30 lines)			Patch
	M	content/renderer/media/webinbandtexttrack_impl.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	content/renderer/media/webinbandtexttrack_impl.cc	View		3 chunks	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/63963002/1

7 years, 1 month ago (2013-11-07 19:21:37 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 1 month ago (2013-11-07 19:37:19 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/63963002/1

7 years, 1 month ago (2013-11-07 19:55:05 UTC) #5

Message was sent while issue was closed.

Change committed as 233835

Expand Messages | Collapse Messages