Fix es5conform.status expectation file.

Fix es5conform.status expectation file.
The strict mode tests in es5conform suite were disabled until now.
The propagation of strict mode flag into eval enabled them but
there are failures due to:
* unimplemented features of strict mode
* some incorrect tests in the suite.

TBR=ager@chromium.org, lrn@chromium.org

BUG=
TEST=es5conform

[Martin Maly, 2011-02-04 22:13:13]

Hi Mads, Lasse,

should have anticipated this one... The strict mode part of the es5conform suite
was hiding behind a gate:

function isStrictSupported() {
  "use strict";
  try {
    eval("with({}){};")
    return false;
  } catch (e) {
    return e instanceof SyntaxError;
  }
}


which I enabled with the eval commit. All of a sudden the strict mode tests
actually run. Some fail because the strict mode implementation is not complete,
others fail because thee tests themselves are not correct in places.

I adjusted the expectations file and put comments in there to note why each test
fails.

Thank you!
Martin

[Rico, 2011-02-07 07:42:25]

Drive by,

A large fraction of your comments are more than 80 characters wide.

Cheers,
Rico

On 2011/02/04 22:13:13, Martin Maly wrote:
> Hi Mads, Lasse,
> 
> should have anticipated this one... The strict mode part of the es5conform
suite
> was hiding behind a gate:
> 
> function isStrictSupported() {
>   "use strict";
>   try {
>     eval("with({}){};")
>     return false;
>   } catch (e) {
>     return e instanceof SyntaxError;
>   }
> }
> 
> 
> which I enabled with the eval commit. All of a sudden the strict mode tests
> actually run. Some fail because the strict mode implementation is not
complete,
> others fail because thee tests themselves are not correct in places.
> 
> I adjusted the expectations file and put comments in there to note why each
test
> fails.
> 
> Thank you!
> Martin

[Lasse Reichstein, 2011-02-07 08:27:18]

LGTM

http://codereview.chromium.org/6396008/diff/1/test/es5conform/es5conform.status
File test/es5conform/es5conform.status (right):

http://codereview.chromium.org/6396008/diff/1/test/es5conform/es5conform.stat...
test/es5conform/es5conform.status:399: # test uses implicit return (which
doesn't seem to work in v8 or safari jsc)
I think it's because the test was originally written for a harness where
returning undefined was considered a success - and the author just forgot to
return the result of the "instanceof" test.
Still a bad test.

(I'm not aware of any JS implementation with "implicit return", so just say that
it fails to return a true value).

http://codereview.chromium.org/6396008/diff/1/test/es5conform/es5conform.stat...
test/es5conform/es5conform.status:434: # Invalid test case per ECMA-262 5th
Edition, 10.1.1, bullet 4
The test seems correct to me.
The Function call creates a function that is not strict, so it should be allowed
to have two "a" parameters. I.e., the result of the test should be to not throw.
How do we fail it?

[Mads Ager (chromium), 2011-02-07 10:25:58]

LGTM, thanks.

[Martin Maly, 2011-02-07 16:50:14]

Fixed line lengths and comments for invalid tests. Thanks!

http://codereview.chromium.org/6396008/diff/1/test/es5conform/es5conform.status
File test/es5conform/es5conform.status (right):

http://codereview.chromium.org/6396008/diff/1/test/es5conform/es5conform.stat...
test/es5conform/es5conform.status:399: # test uses implicit return (which
doesn't seem to work in v8 or safari jsc)
On 2011/02/07 08:27:18, Lasse Reichstein wrote:
> I think it's because the test was originally written for a harness where
> returning undefined was considered a success - and the author just forgot to
> return the result of the "instanceof" test.
> Still a bad test.
> 
> (I'm not aware of any JS implementation with "implicit return", so just say
that
> it fails to return a true value).

Done.

http://codereview.chromium.org/6396008/diff/1/test/es5conform/es5conform.stat...
test/es5conform/es5conform.status:434: # Invalid test case per ECMA-262 5th
Edition, 10.1.1, bullet 4
On 2011/02/07 08:27:18, Lasse Reichstein wrote:
> The test seems correct to me.
> The Function call creates a function that is not strict, so it should be
allowed
> to have two "a" parameters. I.e., the result of the test should be to not
throw.
> How do we fail it?

Actually, the reason is same as above. On success, the test fails to return
true, returning undefined, leading to failure.