Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 639543002: Add cross test for vector itofp and fptoi casts. (Closed)

Created:
6 years, 2 months ago by jvoung (off chromium)
Modified:
6 years, 2 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Add cross test for vector itofp and fptoi casts. Add the SZ runtime functions for unsigned conversion. Add some more cast tests before doing emitIAS for cvt. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=109fa15292072057ebcb12f8a69c496dd2486bf1

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : fix szbuild #

Patch Set 4 : ui const #

Patch Set 5 : stuff #

Total comments: 4

Patch Set 6 : share more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -56 lines) Patch
M crosstest/runtests.sh View 1 chunk +1 line, -0 lines 0 comments Download
M crosstest/test_arith.def View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
M crosstest/test_cast_main.cpp View 1 2 3 4 5 5 chunks +56 lines, -28 lines 0 comments Download
A crosstest/test_cast_vectors.ll View 1 chunk +25 lines, -0 lines 0 comments Download
M crosstest/test_fcmp_main.cpp View 1 2 3 4 5 3 chunks +3 lines, -4 lines 0 comments Download
M crosstest/test_select_main.cpp View 1 2 3 4 5 2 chunks +2 lines, -15 lines 0 comments Download
M pydir/crosstest.py View 1 chunk +3 lines, -0 lines 0 comments Download
M pydir/szbuild.py View 1 2 3 4 5 2 chunks +8 lines, -4 lines 0 comments Download
M runtime/szrt.c View 1 chunk +0 lines, -2 lines 0 comments Download
A runtime/szrt_i686.ll View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.pnacl.ll View 1 2 3 4 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jvoung (off chromium)
6 years, 2 months ago (2014-10-07 21:37:53 UTC) #2
Jim Stichnoth
https://codereview.chromium.org/639543002/diff/80001/crosstest/test_cast_main.cpp File crosstest/test_cast_main.cpp (right): https://codereview.chromium.org/639543002/diff/80001/crosstest/test_cast_main.cpp#newcode94 crosstest/test_cast_main.cpp:94: volatile float Values[] = { How about creating this ...
6 years, 2 months ago (2014-10-07 21:57:47 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/639543002/diff/80001/crosstest/test_cast_main.cpp File crosstest/test_cast_main.cpp (right): https://codereview.chromium.org/639543002/diff/80001/crosstest/test_cast_main.cpp#newcode94 crosstest/test_cast_main.cpp:94: volatile float Values[] = { On 2014/10/07 21:57:47, stichnot ...
6 years, 2 months ago (2014-10-07 22:55:54 UTC) #4
Jim Stichnoth
lgtm
6 years, 2 months ago (2014-10-07 23:49:57 UTC) #5
jvoung (off chromium)
6 years, 2 months ago (2014-10-08 00:22:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
109fa15292072057ebcb12f8a69c496dd2486bf1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698