Issue 639533002: bluetooth: Extend navigator.bluetooth IDL to include Bluetooth interface.

Issue 639533002: bluetooth: Extend navigator.bluetooth IDL to include Bluetooth interface. (Closed)

Created:
6 years, 2 months ago by scheib

Modified:
6 years, 2 months ago

Reviewers:
tkent, haraken

CC:
jsbell, tkent, blink-reviews, Jeffrey Yasskin

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

bluetooth: Extend navigator.bluetooth IDL to include Bluetooth interface. BUG=420275 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183420

Patch Set 1 : GC Compile issue #

Total comments: 3

Patch Set 3 : #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -8 lines)			Patch
A	LayoutTests/bluetooth/idl-Bluetooth.html	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	LayoutTests/bluetooth/idl-NavigatorBluetooth.html	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	Source/modules/bluetooth/Bluetooth.h	View	1 2	1 chunk	+26 lines, -0 lines	0 comments	Download
A +	Source/modules/bluetooth/Bluetooth.idl	View		1 chunk	+8 lines, -4 lines	0 comments	Download
M	Source/modules/bluetooth/NavigatorBluetooth.h	View	1	1 chunk	+23 lines, -2 lines	0 comments	Download
A	Source/modules/bluetooth/NavigatorBluetooth.cpp	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download
M	Source/modules/bluetooth/NavigatorBluetooth.idl	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/modules/modules.gypi	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 16 (6 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheib

Would you Take a look at this GC related compile error, or suggest someone? https://codereview.chromium.org/639533002/diff/40001/Source/modules/bluetooth/NavigatorBluetooth.cpp ...

6 years, 2 months ago (2014-10-08 00:06:10 UTC) #3

Would you Take a look at this GC related compile error, or suggest someone?

https://codereview.chromium.org/639533002/diff/40001/Source/modules/bluetooth...
File Source/modules/bluetooth/NavigatorBluetooth.cpp (right):

https://codereview.chromium.org/639533002/diff/40001/Source/modules/bluetooth...
Source/modules/bluetooth/NavigatorBluetooth.cpp:31: m_bluetooth =
Bluetooth::create();
Compile error:
../../third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.cpp:31:21:
error: no viable overloaded '='
        m_bluetooth = Bluetooth::create();
        ~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/platform/heap/Handle.h:584:17: note: candidate
function not viable: 'this' argument has type 'const
blink::Persistent<Bluetooth>', but method is not marked const
    Persistent& operator=(const Persistent& other)
                ^
../../third_party/WebKit/Source/platform/heap/Handle.h:533:17: note: candidate
function not viable: 'this' argument has type 'const
blink::Persistent<Bluetooth>', but method is not marked const
    Persistent& operator=(U* other)
                ^
../../third_party/WebKit/Source/platform/heap/Handle.h:503:5: note: candidate
function not viable: 'this' argument has type 'const
blink::Persistent<Bluetooth>', but method is not marked const
    WTF_DISALLOW_ZERO_ASSIGNMENT(Persistent);
    ^
../../third_party/WebKit/Source/wtf/NullPtr.h:47:20: note: expanded from macro
'WTF_DISALLOW_ZERO_ASSIGNMENT'
        ClassName& operator=(int) = delete
                   ^
../../third_party/WebKit/Source/platform/heap/Handle.h:540:17: note: candidate
function not viable: 'this' argument has type 'const
blink::Persistent<Bluetooth>', but method is not marked const
    Persistent& operator=(std::nullptr_t)
                ^
../../third_party/WebKit/Source/platform/heap/Handle.h:592:17: note: candidate
template ignored: could not match 'Persistent<type-parameter-0-0,
blink::ThreadLocalPersistents<0> >' against 'blink::Bluetooth *'
    Persistent& operator=(const Persistent<U, RootsAccessor>& other)
                ^
../../third_party/WebKit/Source/platform/heap/Handle.h:600:17: note: candidate
template ignored: could not match 'Member<type-parameter-0-0>' against
'blink::Bluetooth *'
    Persistent& operator=(const Member<U>& other)
                ^
../../third_party/WebKit/Source/platform/heap/Handle.h:608:17: note: candidate
template ignored: could not match 'RawPtr<type-parameter-0-0>' against
'blink::Bluetooth *'
    Persistent& operator=(const RawPtr<U>& other)
                ^
1 error generated.

scheib

tkent, would you take a look at this GC related compile error, I'm not sure ...

6 years, 2 months ago (2014-10-08 00:08:18 UTC) #4

tkent

https://codereview.chromium.org/639533002/diff/40001/Source/modules/bluetooth/NavigatorBluetooth.cpp File Source/modules/bluetooth/NavigatorBluetooth.cpp (right): https://codereview.chromium.org/639533002/diff/40001/Source/modules/bluetooth/NavigatorBluetooth.cpp#newcode31 Source/modules/bluetooth/NavigatorBluetooth.cpp:31: m_bluetooth = Bluetooth::create(); NavigatorBluetooth::bluetooth() is a const function. We ...

6 years, 2 months ago (2014-10-08 00:23:41 UTC) #6

scheib

tkent: Thanks! I've fixed my oversight. haraken: IDL changes.

6 years, 2 months ago (2014-10-08 05:48:47 UTC) #9

scheib

6 years, 2 months ago (2014-10-08 05:49:31 UTC) #10

haraken

LGTM https://codereview.chromium.org/639533002/diff/80001/Source/modules/bluetooth/Bluetooth.h File Source/modules/bluetooth/Bluetooth.h (right): https://codereview.chromium.org/639533002/diff/80001/Source/modules/bluetooth/Bluetooth.h#newcode9 Source/modules/bluetooth/Bluetooth.h:9: #include "platform/heap/Heap.h" Heap.h => Handle.h https://codereview.chromium.org/639533002/diff/80001/Source/modules/bluetooth/Bluetooth.h#newcode13 Source/modules/bluetooth/Bluetooth.h:13: class ...

6 years, 2 months ago (2014-10-08 09:41:16 UTC) #12

scheib

Thanks. https://codereview.chromium.org/639533002/diff/80001/Source/modules/bluetooth/Bluetooth.h File Source/modules/bluetooth/Bluetooth.h (right): https://codereview.chromium.org/639533002/diff/80001/Source/modules/bluetooth/Bluetooth.h#newcode9 Source/modules/bluetooth/Bluetooth.h:9: #include "platform/heap/Heap.h" On 2014/10/08 09:41:16, haraken wrote: > ...

6 years, 2 months ago (2014-10-08 15:31:02 UTC) #13

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639533002/100001

6 years, 2 months ago (2014-10-08 15:31:44 UTC) #15

commit-bot: I haz the power

6 years, 2 months ago (2014-10-08 16:34:23 UTC) #16

Message was sent while issue was closed.

Committed patchset #3 (id:100001) as 183420

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages