Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 639523002: Only use msaa target for blur mask when doAA is true (Closed)

Created:
6 years, 2 months ago by derekf
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Only use msaa target for blur mask when doAA is true BUG=skia:2995 Committed: https://skia.googlesource.com/skia/+/e6efd39a33a9efa5e20c3289384c0e08ef8c9287

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
derekf
Only use msaa target when actually anti-aliasing... Should fix blurrects for issue 2995 because doAA ...
6 years, 2 months ago (2014-10-07 20:29:42 UTC) #2
bsalomon
lgtm, but can you add the test name to expectations/gm/ignored-tests.txt before landing?
6 years, 2 months ago (2014-10-07 20:51:17 UTC) #3
derekf
On 2014/10/07 20:51:17, bsalomon wrote: > lgtm, but can you add the test name to ...
6 years, 2 months ago (2014-10-07 21:26:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639523002/20001
6 years, 2 months ago (2014-10-07 21:35:49 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 21:44:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as e6efd39a33a9efa5e20c3289384c0e08ef8c9287

Powered by Google App Engine
This is Rietveld 408576698