Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 639513002: Pull test utilities from MinidumpMemoryWriter’s test out into their own file (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Pull test utilities from MinidumpMemoryWriter’s test out into their own file. These utilities are also useful to MinidumpThreadWriter’s test. TEST=minidump_test MinidumpMemoryWriter.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9c76cc60db794ded66a219aad8ad1dac8307e860

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -113 lines) Patch
M minidump/minidump.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M minidump/minidump_memory_writer_test.cc View 12 chunks +32 lines, -113 lines 0 comments Download
A minidump/minidump_memory_writer_test_util.h View 1 chunk +91 lines, -0 lines 0 comments Download
A minidump/minidump_memory_writer_test_util.cc View 1 chunk +96 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
https://codereview.chromium.org/639513002/diff/1/minidump/minidump_memory_writer_test_util.cc File minidump/minidump_memory_writer_test_util.cc (right): https://codereview.chromium.org/639513002/diff/1/minidump/minidump_memory_writer_test_util.cc#newcode75 minidump/minidump_memory_writer_test_util.cc:75: if (expected->Memory.Rva != 0) { This new conditional is ...
6 years, 2 months ago (2014-10-07 19:01:56 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-07 21:39:05 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-07 21:58:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c76cc60db794ded66a219aad8ad1dac8307e860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698