Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 63943005: Experimental lexer generator: refactor(TransitionKey) += comments. (Closed)

Created:
7 years, 1 month ago by marja
Modified:
7 years, 1 month ago
Reviewers:
CC:
v8-dev
Visibility:
Public.

Description

Experimental lexer generator: refactor(TransitionKey) += comments. - Add __init__ - Add comments - Rename key_matches -> is_superset_of - reduce -> max BUG= Committed: https://code.google.com/p/v8/source/detail?r=17882

Patch Set 1 #

Patch Set 2 : no __create #

Patch Set 3 : moar comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -22 lines) Patch
M tools/lexer_generator/dfa.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/lexer_generator/nfa.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/lexer_generator/transition_keys.py View 1 2 12 chunks +53 lines, -20 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
marja
7 years, 1 month ago (2013-11-19 14:54:31 UTC) #1
Message was sent while issue was closed.
Committed patchset #3 manually as r17882.

Powered by Google App Engine
This is Rietveld 408576698