Remove use_system_skia and skia_system.gypi

Remove use_system_skia and skia_system.gypi

These are no longer needed/used.

BUG=skia:2350
Committed: https://crrev.com/76be254d3f94eec77254e0642d93cb077ee627f9
Cr-Commit-Position: refs/heads/master@{#301639}

[scroggo, 2014-10-20 16:42:24]

scroggo@google.com changed reviewers:
+ djsollen@google.com, torne@chromium.org

[scroggo, 2014-10-20 16:42:25]

Not sure whether the file is generally needed at all, but removing this
reference allows us to clean up Skia.

[Torne, 2014-10-20 17:06:08]

I don't think we're going to go back to linking to the system skia in webview,
so it should be fine to remove this or anything else related to that.

[djsollen, 2014-10-20 17:06:26]

let's delete public_headers all together now that we don't need it anymore.

[scroggo, 2014-10-20 17:11:26]

On 2014/10/20 17:06:26, djsollen wrote:
> let's delete public_headers all together now that we don't need it anymore.

That's the plan. If we delete it without checking in this change (or a larger
change - is skia_system.gypi even needed anymore?), chrome build fails. (See
https://code.google.com/p/skia/issues/detail?id=2350#c12 , which explains why we
previously reverted a change to delete public_headers.)

[djsollen, 2014-10-21 12:19:41]

On 2014/10/20 17:11:26, scroggo wrote:
> On 2014/10/20 17:06:26, djsollen wrote:
> > let's delete public_headers all together now that we don't need it anymore.
> 
> That's the plan. If we delete it without checking in this change (or a larger
> change - is skia_system.gypi even needed anymore?), chrome build fails. (See
> https://code.google.com/p/skia/issues/detail?id=2350#c12 , which explains why
we
> previously reverted a change to delete public_headers.)

I'll let Torne chime in but I think we should be safe to remove the
"use_system_skia" variable from Chromium and all the code that is conditional on
it.  If that is the case then we should do that first and then delete this
entire file and public_headers.gypi.

[Torne, 2014-10-21 12:20:38]

On 2014/10/21 12:19:41, djsollen wrote:
> On 2014/10/20 17:11:26, scroggo wrote:
> > On 2014/10/20 17:06:26, djsollen wrote:
> > > let's delete public_headers all together now that we don't need it
anymore.
> > 
> > That's the plan. If we delete it without checking in this change (or a
larger
> > change - is skia_system.gypi even needed anymore?), chrome build fails. (See
> > https://code.google.com/p/skia/issues/detail?id=2350#c12 , which explains
why
> we
> > previously reverted a change to delete public_headers.)
> 
> I'll let Torne chime in but I think we should be safe to remove the
> "use_system_skia" variable from Chromium and all the code that is conditional
on
> it.  If that is the case then we should do that first and then delete this
> entire file and public_headers.gypi.

Yeah, I really don't think we can ever go back to using the system skia because
of ABI compat issues in updates, and afaik all the use_system_skia flagged code
is purely for webview (i.e. it doesn't work on any other platform anyway).

[scroggo, 2014-10-23 22:03:47]

On 2014/10/21 12:19:41, djsollen wrote:
> On 2014/10/20 17:11:26, scroggo wrote:
> > On 2014/10/20 17:06:26, djsollen wrote:
> > > let's delete public_headers all together now that we don't need it
anymore.
> > 
> > That's the plan. If we delete it without checking in this change (or a
larger
> > change - is skia_system.gypi even needed anymore?), chrome build fails. (See
> > https://code.google.com/p/skia/issues/detail?id=2350#c12 , which explains
why
> we
> > previously reverted a change to delete public_headers.)
> 
> I'll let Torne chime in but I think we should be safe to remove the
> "use_system_skia" variable from Chromium and all the code that is conditional
on
> it.  If that is the case then we should do that first and then delete this
> entire file and public_headers.gypi.

Done.

[djsollen, 2014-10-24 17:30:33]

Rietveld only shows the gypi as modified, even though it has no contents.  As
long as it actually gets deleted this LGTM.

[scroggo, 2014-10-24 17:35:46]

On 2014/10/24 17:30:33, djsollen wrote:
> Rietveld only shows the gypi as modified, even though it has no contents.  As
> long as it actually gets deleted this LGTM.

Not sure why it shows an M instead of a D, but it appears to be showing the
right
thing for a deleted file when I look at the file itself (and I used git rm
locally).

[scroggo, 2014-10-27 19:25:36]

On 2014/10/24 17:35:46, scroggo wrote:
> On 2014/10/24 17:30:33, djsollen wrote:
> > Rietveld only shows the gypi as modified, even though it has no contents. 
As
> > long as it actually gets deleted this LGTM.
> 
> Not sure why it shows an M instead of a D, but it appears to be showing the
> right
> thing for a deleted file when I look at the file itself (and I used git rm
> locally).

Torne, will you please review when you get a chance? I need someone for the
OWNERS file in android_webview. Thanks

[Torne, 2014-10-28 09:39:49]

lgtm

[scroggo, 2014-10-28 13:40:13]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-10-28 13:41:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/639423005/20001

[commit-bot: I haz the power, 2014-10-28 13:44:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-28 13:44:09]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/74558)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[scroggo, 2014-10-28 14:03:09]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-10-28 14:04:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/639423005/60001

[commit-bot: I haz the power, 2014-10-28 15:42:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-28 15:43:11]

Patchset 4 (id:??) landed as
https://crrev.com/76be254d3f94eec77254e0642d93cb077ee627f9
Cr-Commit-Position: refs/heads/master@{#301639}