Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 639423002: Leak fixed (Closed)

Created:
6 years, 2 months ago by sugoi1
Modified:
6 years, 2 months ago
Reviewers:
bsalomon, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/effects/SkColorCubeFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sugoi1
6 years, 2 months ago (2014-10-09 14:37:24 UTC) #2
sugoi1
Adding Brian as reviewer (Mike seems to be busy)
6 years, 2 months ago (2014-10-09 14:50:00 UTC) #4
mtklein
lgtm
6 years, 2 months ago (2014-10-09 14:53:27 UTC) #7
bsalomon
lgtm (heads up in case another patch is needed, I'm at home sick today and ...
6 years, 2 months ago (2014-10-09 14:53:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639423002/1
6 years, 2 months ago (2014-10-09 14:54:02 UTC) #10
sugoi1
On 2014/10/09 14:53:39, bsalomon wrote: > lgtm (heads up in case another patch is needed, ...
6 years, 2 months ago (2014-10-09 15:07:19 UTC) #11
reed1
lgtm
6 years, 2 months ago (2014-10-09 15:07:46 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 15:09:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 9a7f29ee5e40071d3b3025d22bbfa58953e6c821

Powered by Google App Engine
This is Rietveld 408576698