Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 639393002: Remove Observer methods in RTCVideoEncoderFactory. (Closed)

Created:
6 years, 2 months ago by pbos
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Observer methods in RTCVideoEncoderFactory. These methods are no-ops in the current implementations and are going away in the upstream interface, where a default implementation is provided in the interrim. R=tommi@chromium.org BUG=webrtc:3876 Committed: https://crrev.com/6650ccfc57f15543efdba8eaab758b6f2071f32b Cr-Commit-Position: refs/heads/master@{#299089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M content/renderer/media/rtc_video_encoder_factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_video_encoder_factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
pbos
6 years, 2 months ago (2014-10-09 13:40:12 UTC) #1
pbos
On 2014/10/09 13:40:12, pbos wrote: Ptal, and if lgtm please cq. :)
6 years, 2 months ago (2014-10-09 13:40:25 UTC) #2
tommi (sloooow) - chröme
lgtm
6 years, 2 months ago (2014-10-09 13:54:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639393002/1
6 years, 2 months ago (2014-10-09 13:55:54 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
6 years, 2 months ago (2014-10-09 15:30:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639393002/1
6 years, 2 months ago (2014-10-10 11:07:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 11:08:09 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 11:08:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6650ccfc57f15543efdba8eaab758b6f2071f32b
Cr-Commit-Position: refs/heads/master@{#299089}

Powered by Google App Engine
This is Rietveld 408576698