Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 639383002: Fix computation of UTC time from local time at DST change points. (Closed)

Created:
6 years, 2 months ago by ulan
Modified:
6 years, 2 months ago
Reviewers:
Yang, PhistucK
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix computation of UTC time from local time at DST change points. This also reverts r23606, which was an incorrect fix. BUG=v8:3116, chromium:417640, chromium:415424 LOG=Y TEST=mjsunit/regress/regress-3116.js R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24499

Patch Set 1 #

Patch Set 2 : Reformat tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -9 lines) Patch
M src/date.h View 1 chunk +39 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-3116.js View 1 1 chunk +314 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
6 years, 2 months ago (2014-10-09 13:42:12 UTC) #2
Yang
On 2014/10/09 13:42:12, ulan wrote: > PTAL lgtm.
6 years, 2 months ago (2014-10-09 13:54:34 UTC) #3
ulan
Committed patchset #2 (id:20001) manually as 24499 (presubmit successful).
6 years, 2 months ago (2014-10-09 14:17:45 UTC) #4
PhistucK
115 // Literally following spec here leads to incorrect time computation at 116 // the ...
6 years, 2 months ago (2014-10-11 08:59:08 UTC) #5
PhistucK
6 years, 2 months ago (2014-10-11 09:00:59 UTC) #7
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698