Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 639343003: Fix SVGResources::hasResourceData predicate to match method name (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Fix SVGResources::hasResourceData predicate to match method name Current predicate is "has-no-resource-data". Negate, and negate users. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/core/rendering/svg/SVGResources.cpp View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
6 years, 2 months ago (2014-10-20 13:21:37 UTC) #2
f(malita)
lgtm
6 years, 2 months ago (2014-10-20 14:07:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639343003/1
6 years, 2 months ago (2014-10-20 14:09:00 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 14:23:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183983

Powered by Google App Engine
This is Rietveld 408576698