Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 639333003: Delete the old WebSocket implementation. (Closed)

Created:
6 years, 2 months ago by yhirano
Modified:
6 years, 2 months ago
CC:
blink-reviews, mkwst+moarreviews_chromium.org, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Delete the old WebSocket implementation. The WebSocket implementation has moved to chrome. As it is stable now, let's delete the old implementation. This CL doesn't delete some platform/ and web/ classes, as some chromium-side code depends on them. BUG=423201 R=ricea@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183642

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4991 lines) Patch
M Source/modules/modules.gypi View 1 2 chunks +0 lines, -19 lines 0 comments Download
D Source/modules/websockets/MainThreadWebSocketChannel.h View 1 1 chunk +0 lines, -252 lines 0 comments Download
D Source/modules/websockets/MainThreadWebSocketChannel.cpp View 1 chunk +0 lines, -865 lines 0 comments Download
M Source/modules/websockets/WebSocketChannel.cpp View 2 chunks +1 line, -6 lines 0 comments Download
D Source/modules/websockets/WebSocketDeflateFramer.h View 1 chunk +0 lines, -115 lines 0 comments Download
D Source/modules/websockets/WebSocketDeflateFramer.cpp View 1 1 chunk +0 lines, -228 lines 0 comments Download
D Source/modules/websockets/WebSocketDeflater.h View 1 chunk +0 lines, -104 lines 0 comments Download
D Source/modules/websockets/WebSocketDeflater.cpp View 1 chunk +0 lines, -235 lines 0 comments Download
D Source/modules/websockets/WebSocketDeflaterTest.cpp View 1 chunk +0 lines, -156 lines 0 comments Download
D Source/modules/websockets/WebSocketExtensionDispatcher.h View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/modules/websockets/WebSocketExtensionDispatcher.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
D Source/modules/websockets/WebSocketExtensionDispatcherTest.cpp View 1 1 chunk +0 lines, -184 lines 0 comments Download
D Source/modules/websockets/WebSocketExtensionParser.h View 1 chunk +0 lines, -84 lines 0 comments Download
D Source/modules/websockets/WebSocketExtensionParser.cpp View 1 chunk +0 lines, -163 lines 0 comments Download
D Source/modules/websockets/WebSocketExtensionParserTest.cpp View 1 chunk +0 lines, -185 lines 0 comments Download
D Source/modules/websockets/WebSocketExtensionProcessor.h View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/modules/websockets/WebSocketHandshake.h View 1 chunk +0 lines, -136 lines 0 comments Download
D Source/modules/websockets/WebSocketHandshake.cpp View 1 chunk +0 lines, -556 lines 0 comments Download
D Source/modules/websockets/WebSocketPerMessageDeflate.h View 1 chunk +0 lines, -93 lines 0 comments Download
D Source/modules/websockets/WebSocketPerMessageDeflate.cpp View 1 1 chunk +0 lines, -266 lines 0 comments Download
D Source/modules/websockets/WebSocketPerMessageDeflateTest.cpp View 1 chunk +0 lines, -512 lines 0 comments Download
M Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D Source/platform/network/SocketStreamHandle.h View 1 chunk +0 lines, -85 lines 0 comments Download
D Source/platform/network/SocketStreamHandle.cpp View 1 chunk +0 lines, -292 lines 0 comments Download
D Source/platform/network/SocketStreamHandleClient.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/platform/network/SocketStreamHandleInternal.h View 1 chunk +0 lines, -84 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 3 chunks +0 lines, -7 lines 0 comments Download
M Source/web/WebSocketImpl.cpp View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
yhirano
6 years, 2 months ago (2014-10-10 04:18:33 UTC) #1
Adam Rice
lgtm https://codereview.chromium.org/639333003/diff/20001/Source/platform/blink_platform.gypi File Source/platform/blink_platform.gypi (left): https://codereview.chromium.org/639333003/diff/20001/Source/platform/blink_platform.gypi#oldcode727 Source/platform/blink_platform.gypi:727: 'network/SocketStreamError.cpp', Is it safe not to compile this ...
6 years, 2 months ago (2014-10-10 05:29:19 UTC) #2
yhirano
https://codereview.chromium.org/639333003/diff/20001/Source/platform/blink_platform.gypi File Source/platform/blink_platform.gypi (left): https://codereview.chromium.org/639333003/diff/20001/Source/platform/blink_platform.gypi#oldcode727 Source/platform/blink_platform.gypi:727: 'network/SocketStreamError.cpp', On 2014/10/10 05:29:19, Adam Rice wrote: > Is ...
6 years, 2 months ago (2014-10-10 10:09:16 UTC) #3
yhirano
6 years, 2 months ago (2014-10-10 10:09:56 UTC) #5
yhirano
Jochen, can you review web/ and public/ changes?
6 years, 2 months ago (2014-10-10 10:10:24 UTC) #6
Mike West
web/ and public/ LGTM. Deleting code is wonderful.
6 years, 2 months ago (2014-10-10 10:13:36 UTC) #8
Mike West
Would you mind filing a separate bug to cover removing the old implementation, and set ...
6 years, 2 months ago (2014-10-10 10:16:18 UTC) #9
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-10 11:13:15 UTC) #10
yhirano
On 2014/10/10 10:16:18, Mike West wrote: > Would you mind filing a separate bug to ...
6 years, 2 months ago (2014-10-14 03:37:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639333003/150001
6 years, 2 months ago (2014-10-14 03:38:20 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 04:42:06 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:150001) as 183642

Powered by Google App Engine
This is Rietveld 408576698