Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Issue 639293008: Make CSS resize property non-inherited. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
Reviewers:
andersr, Timothy Loh
CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make CSS resize property non-inherited. Align with CSS UI spec[1] and Gecko. [1] http://dev.w3.org/csswg/css-ui/#resize R=andersr@opera.com,timloh@chromium.org BUG=425552 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184176

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed review issues #

Patch Set 3 : New baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -23 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/content-gains-scrollbars-expected.txt View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M LayoutTests/compositing/overflow/overflow-scrollbar-layers-expected.txt View 1 2 1 chunk +1 line, -7 lines 0 comments Download
A LayoutTests/fast/overflow/resize-inherit.html View 1 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/fast/overflow/resize-inherit-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
rune
6 years, 2 months ago (2014-10-21 15:06:29 UTC) #1
Timothy Loh
Can you mention whether other browsers behave correctly in the patch description? https://codereview.chromium.org/639293008/diff/1/LayoutTests/fast/overflow/resize-inherit.html File LayoutTests/fast/overflow/resize-inherit.html ...
6 years, 2 months ago (2014-10-21 15:14:00 UTC) #2
rune
https://codereview.chromium.org/639293008/diff/1/LayoutTests/fast/overflow/resize-inherit.html File LayoutTests/fast/overflow/resize-inherit.html (right): https://codereview.chromium.org/639293008/diff/1/LayoutTests/fast/overflow/resize-inherit.html#newcode13 LayoutTests/fast/overflow/resize-inherit.html:13: resize: both; On 2014/10/21 15:14:00, Timothy Loh wrote: > ...
6 years, 2 months ago (2014-10-21 15:26:04 UTC) #3
rune
On 2014/10/21 15:14:00, Timothy Loh wrote: > Can you mention whether other browsers behave correctly ...
6 years, 2 months ago (2014-10-21 15:28:02 UTC) #4
Timothy Loh
On 2014/10/21 15:28:02, rune wrote: > On 2014/10/21 15:14:00, Timothy Loh wrote: > > Can ...
6 years, 2 months ago (2014-10-21 15:30:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639293008/20001
6 years, 2 months ago (2014-10-21 15:33:40 UTC) #7
rune
On 2014/10/21 15:30:39, Timothy Loh wrote: > FYI you can easily get screenshots in various ...
6 years, 2 months ago (2014-10-21 15:44:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/30221)
6 years, 2 months ago (2014-10-21 16:42:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639293008/40001
6 years, 2 months ago (2014-10-22 11:19:57 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 12:39:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184176

Powered by Google App Engine
This is Rietveld 408576698