Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 639293007: Just define int64 and uint64 as int64_t and uint64_t. (Closed)

Created:
6 years, 2 months ago by wtc
Modified:
6 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Just define int64 and uint64 as int64_t and uint64_t. The NSPR problem was fixed in NSPR 4.9.5. Right now we require NSS 3.14.3, which requires NSPR 4.9.5. R=viettrungluu@chromium.org,mark@chromium.org BUG= Committed: https://crrev.com/48c7b1fae40c90d0d7dd5b7a53bb194fd85f9b07 Cr-Commit-Position: refs/heads/master@{#300546}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M base/basictypes.h View 1 chunk +3 lines, -16 lines 1 comment Download

Messages

Total messages: 15 (5 generated)
wtc
Please review. You can verify this CL is safe as follows: 1. Open crypto/nss_util.cc and ...
6 years, 2 months ago (2014-10-20 21:44:38 UTC) #2
viettrungluu
LGTM, thanks.
6 years, 2 months ago (2014-10-20 21:51:30 UTC) #3
wtc
Mark: please review. Thanks.
6 years, 2 months ago (2014-10-20 23:01:58 UTC) #5
Mark Mentovai
LGTM
6 years, 2 months ago (2014-10-21 03:28:32 UTC) #6
wtc
https://codereview.chromium.org/639293007/diff/1/base/basictypes.h File base/basictypes.h (left): https://codereview.chromium.org/639293007/diff/1/base/basictypes.h#oldcode36 base/basictypes.h:36: #if defined(__LP64__) && !defined(OS_MACOSX) && !defined(OS_OPENBSD) I just realized ...
6 years, 2 months ago (2014-10-21 18:08:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639293007/1
6 years, 2 months ago (2014-10-21 18:09:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/65622)
6 years, 2 months ago (2014-10-21 18:27:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639293007/1
6 years, 2 months ago (2014-10-21 20:24:52 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 20:26:34 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 20:27:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48c7b1fae40c90d0d7dd5b7a53bb194fd85f9b07
Cr-Commit-Position: refs/heads/master@{#300546}

Powered by Google App Engine
This is Rietveld 408576698