Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 639293006: [turbofan] Move node matchers to separate file. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Move node matchers to separate file. TEST=unittests R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1147 lines) Patch
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/graph-unittest.h View 3 chunks +1 line, -119 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 2 chunks +1 line, -883 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/unittests/compiler/node-test-utils.h View 3 chunks +10 lines, -59 lines 0 comments Download
A + test/unittests/compiler/node-test-utils.cc View 2 chunks +1 line, -83 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-20 11:23:13 UTC) #1
Sven Panne
lgtm
6 years, 2 months ago (2014-10-20 11:25:53 UTC) #2
Benedikt Meurer
6 years, 2 months ago (2014-10-20 11:26:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24729 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698