Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 639293005: Content Shell: Introduce LayoutTestContentBrowserClient (Closed)

Created:
6 years, 2 months ago by Peter Beverloo
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Content Shell: Introduce LayoutTestContentBrowserClient This starts splitting off layout-test specific bits from the ShellContentBrowserClient in a separate class. More patches will follow for moving the other features. BUG=420994 Committed: https://crrev.com/cd7abb42cf832b976dbb1eb958bb7047cfc26fec Cr-Commit-Position: refs/heads/master@{#300097}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -185 lines) Patch
M content/content_shell.gypi View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 2 chunks +11 lines, -5 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_content_browser_client.h View 1 chunk +42 lines, -0 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_content_browser_client.cc View 1 chunk +78 lines, -0 lines 0 comments Download
A + content/shell/browser/layout_test/layout_test_notification_manager.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + content/shell/browser/layout_test/layout_test_notification_manager.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 4 chunks +0 lines, -16 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 4 chunks +0 lines, -50 lines 0 comments Download
M content/shell/browser/shell_message_filter.cc View 4 chunks +8 lines, -7 lines 0 comments Download
D content/shell/browser/shell_notification_manager.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/shell/browser/shell_notification_manager.cc View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Peter Beverloo
6 years, 2 months ago (2014-10-16 14:54:46 UTC) #2
Mike West
LGTM, thanks.
6 years, 2 months ago (2014-10-16 19:38:48 UTC) #3
Mike West
https://codereview.chromium.org/639293005/diff/1/content/shell/app/shell_main_delegate.cc File content/shell/app/shell_main_delegate.cc (right): https://codereview.chromium.org/639293005/diff/1/content/shell/app/shell_main_delegate.cc#newcode313 content/shell/app/shell_main_delegate.cc:313: browser_client_.reset(new LayoutTestContentBrowserClient); Nit: I think I'd prefer a ternary ...
6 years, 2 months ago (2014-10-16 19:39:57 UTC) #4
Peter Beverloo
Thanks! Running the try-jobs again including a few Blink ones, I'll submit once they're happy. ...
6 years, 2 months ago (2014-10-17 11:06:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/639293005/20001
6 years, 2 months ago (2014-10-17 12:57:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-17 13:34:13 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 13:34:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd7abb42cf832b976dbb1eb958bb7047cfc26fec
Cr-Commit-Position: refs/heads/master@{#300097}

Powered by Google App Engine
This is Rietveld 408576698