Allow POSIX callers to specify a new file's mode.

base/files/file_util_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_util.h"
 
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <libgen.h>
@@ skipping 675 matching lines @@
   int fd = HANDLE_EINTR(creat(filename.value().c_str(), 0640));
   if (fd < 0)
     return -1;
 
   int bytes_written = WriteFileDescriptor(fd, data, size) ? size : -1;
   if (IGNORE_EINTR(close(fd)) < 0)
     return -1;
   return bytes_written;
 }
 
+bool WriteFileWithMode(const FilePath& filename, const char* data, int size,
+                       mode_t mode) {
+  ThreadRestrictions::AssertIOAllowed();
+  int fd = HANDLE_EINTR(creat(filename.value().c_str(), mode));

[rvargas (doing something else), 2014/10/22 00:57:38]

tiny nit: declare fd (or file) directly to be a ScopedFD here, and use
is_valid() below.

[palmer, 2014/10/22 01:03:02]

Done.

+  if (fd < 0)
+    return false;
+
+  ScopedFD file(fd);
+  bool status = WriteFileDescriptor(file.get(), data, size);

[rvargas (doing something else), 2014/10/22 00:57:38]

tiny nit: return directly here.

[palmer, 2014/10/22 01:03:02]

Done.

+  return status;
+}
+
 bool WriteFileDescriptor(const int fd, const char* data, int size) {
   // Allow for partial writes.
   ssize_t bytes_written_total = 0;
   for (ssize_t bytes_written_partial = 0; bytes_written_total < size;
        bytes_written_total += bytes_written_partial) {
     bytes_written_partial =
         HANDLE_EINTR(write(fd, data + bytes_written_total,
                            size - bytes_written_total));
     if (bytes_written_partial < 0)
       return false;
@@ skipping 215 matching lines @@
     result = false;
 
   return result;
 }
 #endif  // !defined(OS_MACOSX)
 
 }  // namespace internal
 
 #endif  // !defined(__native_client_nonsfi__)
 }  // namespace base