Remote assistance on Chrome OS Part IV - It2MeHost

remoting/host/continue_window_chromeos.cc

Index: remoting/host/continue_window_chromeos.cc
diff --git a/remoting/host/continue_window_chromeos.cc b/remoting/host/continue_window_chromeos.cc
new file mode 100644
index 0000000000000000000000000000000000000000..77b3463a18b6c2a68ab8999cb92a964d5eb9b7a0
--- /dev/null
+++ b/remoting/host/continue_window_chromeos.cc
@@ -0,0 +1,40 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/host/continue_window.h"
+
+namespace remoting {
+
+class ContinueWindowAura : public ContinueWindow {

[rmsousa, 2014/10/14 00:18:25]

This isn't really an "Aura" implementation, just an empty implementation.

If this is supposed to remain empty, please name it appropriately, and add a
code comment explaining why these UI elements aren't needed in Chrome OS.

If you do plan to add Aura implementations of this later on, please add a TODO
to that effect. Also, please explain why it is safe to land this change without
the UI elements (e.g. if the it2me code is currently guaranteed to be
unreachable)

[kelvinp, 2014/10/15 23:03:10]

Done.

+ public:
+  ContinueWindowAura();
+  virtual ~ContinueWindowAura();
+
+ protected:
+  // ContinueWindow overrides.
+  virtual void ShowUi() OVERRIDE;
+  virtual void HideUi() OVERRIDE;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ContinueWindowAura);
+};
+
+ContinueWindowAura::ContinueWindowAura() {
+}
+
+ContinueWindowAura::~ContinueWindowAura() {
+}
+
+void ContinueWindowAura::ShowUi() {

[Jamie, 2014/10/14 01:18:42]

These empty methods should all have NOTIMPLEMENTED().

[kelvinp, 2014/10/15 23:03:10]

Those function will be called on ChromeOS and can't have NOTIMPLEMENTED().  I
will add a TODO statement

+}
+
+void ContinueWindowAura::HideUi() {
+}
+
+// static
+scoped_ptr<HostWindow> HostWindow::CreateContinueWindow() {
+  return scoped_ptr<HostWindow>(new ContinueWindowAura());
+}
+
+}  // namespace remoting