Remote assistance on Chrome OS Part IV - It2MeHost

remoting/host/policy_hack/policy_watcher_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "remoting/host/dns_blackhole_checker.h"
@@ skipping 81 matching lines @@
 #endif
   }
 
  protected:
   void StartWatching() {
     policy_watcher_->StartWatching(policy_callback_);
     base::RunLoop().RunUntilIdle();
   }
 
   void StopWatching() {
-    base::WaitableEvent stop_event(false, false);
-    policy_watcher_->StopWatching(&stop_event);
+    EXPECT_CALL(*this, PostPolicyWatcherShutdown()).Times(1);

[Wez, 2014/10/17 17:58:01]

You shouldn't mix call expectations in with actually running the code; they need
to be set up before you start running code. In this case you will already have
called e.g. StartWatching()so the policy watcher will be active at the point
where you're adding this now expectation into the mix.

[kelvinp, 2014/10/20 00:21:18]

I felt the same way when I saw the EXPECT_EQ in the original code as well.  But
then I realized that StopWatching is manually called in the test case.  The test
here is trying to verify that whenever StopWatching is called, the appropriate
callback is invoked (or stop_event is signaled before this change) and not so
much about whether StopWatching is being called.  I am going to leave it as it
is.

+    policy_watcher_->StopWatching(base::Bind(
+        &PolicyWatcherTest::PostPolicyWatcherShutdown, base::Unretained(this)));
     base::RunLoop().RunUntilIdle();
-    EXPECT_EQ(true, stop_event.IsSignaled());
   }
 
+  MOCK_METHOD0(PostPolicyWatcherShutdown, void());
+
   static const char* kHostDomain;
   static const char* kPortRange;
   base::MessageLoop message_loop_;
   scoped_refptr<base::MessageLoopProxy> message_loop_proxy_;
   MockPolicyCallback mock_policy_callback_;
   PolicyWatcher::PolicyCallback policy_callback_;
   scoped_ptr<FakePolicyWatcher> policy_watcher_;
   base::DictionaryValue empty_;
   base::DictionaryValue nat_true_;
   base::DictionaryValue nat_false_;
@@ skipping 279 matching lines @@
 
   StartWatching();
   policy_watcher_->SetPolicies(&empty_);
   policy_watcher_->SetPolicies(&port_range_full_);
   policy_watcher_->SetPolicies(&port_range_empty_);
   StopWatching();
 }
 
 }  // namespace policy_hack
 }  // namespace remoting