Remote assistance on Chrome OS Part IV - It2MeHost

remoting/host/it2me/it2me_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_IT2ME_IT2ME_HOST_H_
 #define REMOTING_HOST_IT2ME_IT2ME_HOST_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 105 matching lines @@
                            const base::TimeDelta& lifetime);
 
   // Shuts down |host_| on the network thread and posts ShutdownOnUiThread()
   // to shut down UI thread resources.
   void ShutdownOnNetworkThread();
 
   // Shuts down |desktop_environment_factory_| and |policy_watcher_| on
   // the UI thread.
   void ShutdownOnUiThread();
 
+  // Called when |policy_watcher_| has stopped listening for changes and it is
+  // safe to delete the |policy_watcher_| object.

[Wez, 2014/10/17 17:58:01]

nit: ... safe to delete it.

[kelvinp, 2014/10/20 00:21:17]

Done.

+  void OnPolicyWatcherShutdown();
+
   // Called when initial policies are read, and when they change.
   void OnPolicyUpdate(scoped_ptr<base::DictionaryValue> policies);
 
   // Handlers for NAT traversal and host domain policies.
   void UpdateNatPolicy(bool nat_traversal_enabled);
   void UpdateHostDomainPolicy(const std::string& host_domain);
 
   // Caller supplied fields.
 
   // The creator of the It2MeHost object owns the the host context and is
   // responsible for keeping it alive throughout the liftime of the host.
   ChromotingHostContext* host_context_;

[Wez, 2014/10/17 17:58:01]

That doesn't make sense; the It2Me object is ref-counted, so the caller has no
control over its lifetime.

Can you just have the It2MeHost own the context? You create a new one for each
host instance anyway.

[kelvinp, 2014/10/20 00:21:17]

We can but this would mean that it2meHost would need a context factory as a new
context is created each time.

+
   scoped_refptr<base::SingleThreadTaskRunner> task_runner_;

[Wez, 2014/10/17 17:58:01]

Add a comment, or better still rename this to ui_task_runner, to clarify the
distinction between it and the network task runner, below.

[kelvinp, 2014/10/20 00:21:17]

I have removed network_task_runner.

+  scoped_refptr<base::SingleThreadTaskRunner> network_task_runner_;

[Wez, 2014/10/17 17:58:01]

Why have you pulled this out of the host context?

[kelvinp, 2014/10/20 00:21:18]

Because It2MeHost outlives the host context and we still need the
network_task_runner() on shutdown.  

+
   base::WeakPtr<It2MeHost::Observer> observer_;
   XmppSignalStrategy::XmppServerConfig xmpp_server_config_;
   std::string directory_bot_jid_;
 
   It2MeHostState state_;
 
   scoped_refptr<RsaKeyPair> host_key_pair_;
   scoped_ptr<SignalStrategy> signal_strategy_;
   scoped_ptr<RegisterSupportHostRequest> register_request_;
   scoped_ptr<HostStatusLogger> host_status_logger_;
@@ skipping 39 matching lines @@
       const XmppSignalStrategy::XmppServerConfig& xmpp_server_config,
       const std::string& directory_bot_jid);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(It2MeHostFactory);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_IT2ME_IT2ME_HOST_H_