Remote assistance on Chrome OS Part IV - It2MeHost

chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/messaging/native_message_host.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/values.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/api/messaging/native_messaging_test_util.h"
+#include "components/policy/core/common/policy_service.h"
 #include "extensions/common/constants.h"
+#include "extensions/common/switches.h"
 #include "extensions/common/url_pattern.h"
+#include "net/url_request/url_request_context_getter.h"
+#include "remoting/host/it2me/it2me_native_messaging_host.h"
 #include "ui/gfx/native_widget_types.h"
 #include "url/gurl.h"
 
 namespace extensions {
 
 namespace {
 
-// A simple NativeMesageHost that echoes the received message. It is currently
-// used for testing.
-// TODO(kelvinp): Replace this class once Remote Assistance in process host
-// is implemented.
+// A simple NativeMesageHost that mimics the implementation of

[Wez, 2014/10/17 17:57:59]

typo

[kelvinp, 2014/10/20 00:21:16]

I think both mimics and implementation are spelled correctly

[Wez, 2014/10/20 01:16:13]

Still typo ;)

+// chrome/test/data/native_messaging/native_hosts/echo.py. It is currently
+// used for testing by ExtensionApiTest::NativeMessagingBasic.
 
 const char* const kEchoHostOrigins[] = {
     // ScopedTestNativeMessagingHost::kExtensionId
     "chrome-extension://knldjmfmopnpolahpmmgbagdohdnhkik/"};
 
 class EchoHost : public NativeMessageHost {
  public:
   static scoped_ptr<NativeMessageHost> Create() {
     return scoped_ptr<NativeMessageHost>(new EchoHost());
   }
@@ skipping 40 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(EchoHost);
 };
 
 struct BuiltInHost {
   const char* const name;
   const char* const* const allowed_origins;
   int allowed_origins_count;
   scoped_ptr<NativeMessageHost>(*create_function)();
 };
 
+scoped_ptr<NativeMessageHost> CreateIt2MeHost() {
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableRemoteAssistance)) {
+    return remoting::It2MeNativeMessagingHost::CreateForChromeOS(
+        g_browser_process->system_request_context(),
+        g_browser_process->policy_service());
+  }
+  return nullptr;
+}
+
 // If you modify the list of allowed_origins, don't forget to update
 // remoting/host/it2me/com.google.chrome.remote_assistance.json.jinja2
 // to keep the two lists in sync.
 // TODO(kelvinp): Load the native messaging manifest as a resource file into
 // chrome and fetch the list of allowed_origins from the manifest.

[Wez, 2014/10/17 17:57:59]

nit: Is there a bug filed for that cleanup?

[kelvinp, 2014/10/20 00:21:16]

Done.

-/*const char* const kRemotingIt2MeOrigins[] = {
+const char* const kRemotingIt2MeOrigins[] = {
     "chrome-extension://ljacajndfccfgnfohlgkdphmbnpkjflk/",
     "chrome-extension://gbchcmhmhahfdphkhkmpfmihenigjmpp/",
     "chrome-extension://kgngmbheleoaphbjbaiobfdepmghbfah/",
     "chrome-extension://odkaodonbgfohohmklejpjiejmcipmib/",
     "chrome-extension://dokpleeekgeeiehdhmdkeimnkmoifgdd/",
     "chrome-extension://ajoainacpilcemgiakehflpbkbfipojk/",
-    "chrome-extension://hmboipgjngjoiaeicfdifdoeacilalgc/"};*/
+    "chrome-extension://hmboipgjngjoiaeicfdifdoeacilalgc/"};
 
 static const BuiltInHost kBuiltInHost[] = {
     {"com.google.chrome.test.echo", // ScopedTestNativeMessagingHost::kHostName
      kEchoHostOrigins,
      arraysize(kEchoHostOrigins),
      &EchoHost::Create},
+     {"com.google.chrome.remote_assistance",
+     kRemotingIt2MeOrigins,
+     arraysize(kRemotingIt2MeOrigins),
+     &CreateIt2MeHost},
 };
 
 bool MatchesSecurityOrigin(const BuiltInHost& host,
                            const std::string& extension_id) {
   GURL origin(std::string(kExtensionScheme) + "://" + extension_id);
   for (int i = 0; i < host.allowed_origins_count; i++) {
     URLPattern allowed_origin(URLPattern::SCHEME_ALL, host.allowed_origins[i]);
     if (allowed_origin.MatchesSecurityOrigin(origin)) {
       return true;
     }
@@ skipping 18 matching lines @@
       }
       *error = kForbiddenError;
       return nullptr;
     }
   }
   *error = kNotFoundError;
   return nullptr;
 }
 
 }  // namespace extensions