Remote assistance on Chrome OS Part IV - It2MeHost

remoting/host/policy_hack/policy_watcher_chromeos.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/host/policy_hack/policy_watcher.h"
+
+#include "base/single_thread_task_runner.h"
+#include "components/policy/core/common/policy_service.h"
+
+using namespace policy;
+
+namespace remoting {
+namespace policy_hack {
+
+namespace {
+
+class PolicyWatcherChromeOS : public PolicyWatcher,
+                              public PolicyService::Observer {
+ public:
+  PolicyWatcherChromeOS(scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+                        PolicyService* policy_service);
+
+  virtual ~PolicyWatcherChromeOS() {}
+
+  // PolicyService::Observer implementation.
+  virtual void OnPolicyUpdated(const PolicyNamespace& ns,
+                               const PolicyMap& previous,
+                               const PolicyMap& current) OVERRIDE;
+
+ protected:
+  // PolicyWatcher overrides.
+  virtual void Reload() OVERRIDE;
+  virtual void StartWatchingInternal() OVERRIDE;
+  virtual void StopWatchingInternal() OVERRIDE;
+
+ private:
+  // Converts a policy map to DictionaryValues.
+  scoped_ptr<base::DictionaryValue> GetPolicyValues(const PolicyMap& map);

[Jamie, 2014/10/14 01:18:42]

I don't think this needs to be a separate method, unless you think you're going
to use it elsewhere. If it was inlined in Reload, you wouldn't need a DCHECK on
the result (because it would clearly be the result of "new"), and the reader
wouldn't have to think about the circumstances under which it might be null.

[kelvinp, 2014/10/15 23:03:10]

Done.

+
+  PolicyService* policy_service_;
+
+  DISALLOW_COPY_AND_ASSIGN(PolicyWatcherChromeOS);
+};
+
+PolicyWatcherChromeOS::PolicyWatcherChromeOS(
+    scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+    PolicyService* policy_service)
+    : PolicyWatcher(task_runner), policy_service_(policy_service) {
+  DCHECK(policy_service_);
+}
+
+void PolicyWatcherChromeOS::OnPolicyUpdated(const PolicyNamespace& ns,
+                                       const PolicyMap& previous,

[Jamie, 2014/10/14 01:18:42]

Indentation.

[kelvinp, 2014/10/15 23:03:10]

Done.

+                                       const PolicyMap& current) {
+  Reload();
+}
+
+void PolicyWatcherChromeOS::Reload(){
+  const PolicyMap& map = policy_service_->GetPolicies(
+      PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()));
+  scoped_ptr<base::DictionaryValue> policy_dict = GetPolicyValues(map);
+  DCHECK(policy_dict);
+  UpdatePolicies(policy_dict.get());
+};
+
+void PolicyWatcherChromeOS::StartWatchingInternal() {
+  policy_service_->AddObserver(POLICY_DOMAIN_CHROME, this);
+  Reload();
+};
+
+void PolicyWatcherChromeOS::StopWatchingInternal(){
+  policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, this);
+};
+
+scoped_ptr<base::DictionaryValue> PolicyWatcherChromeOS::GetPolicyValues(
+    const PolicyMap& map) {
+  scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue());
+  for (PolicyMap::const_iterator it = map.begin(); it != map.end(); it++) {
+    result->Set(it->first, it->second.value->DeepCopy());
+  }
+  return result.Pass();
+}
+
+}  // namespace
+
+PolicyWatcher* PolicyWatcher::Create(
+    ChromotingHostContext* context,
+    scoped_refptr<base::SingleThreadTaskRunner> task_runner) {
+  return new PolicyWatcherChromeOS(task_runner,
+                                   context->policy_service());
+}
+
+}  // namespace policy_hack
+}  // namespace remoting